Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2301653002: [BattOr] Add mac BattOr test for steady state cases. (Closed)

Created:
4 years, 3 months ago by rnephew (Reviews Here)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[BattOr] Add mac BattOr test for steady state cases. BUG=640398, 638365, 639308 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/6380c710d7ee2d6739e563d2957fc7475d663f70 Cr-Commit-Position: refs/heads/master@{#415832}

Patch Set 1 #

Total comments: 2

Patch Set 2 : [BattOr] Add mac BattOr test for steady state cases. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M tools/perf/benchmarks/battor.py View 1 chunk +11 lines, -0 lines 0 comments Download
M tools/perf/page_sets/idle_after_loading_stories.py View 1 1 chunk +16 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
rnephew (Reviews Here)
4 years, 3 months ago (2016-08-31 20:43:29 UTC) #3
erikchen
lgtm https://codereview.chromium.org/2301653002/diff/1/tools/perf/page_sets/idle_after_loading_stories.py File tools/perf/page_sets/idle_after_loading_stories.py (right): https://codereview.chromium.org/2301653002/diff/1/tools/perf/page_sets/idle_after_loading_stories.py#newcode23 tools/perf/page_sets/idle_after_loading_stories.py:23: def __init__(self, wait_in_seconds=0): do we need default values ...
4 years, 3 months ago (2016-08-31 20:51:24 UTC) #4
rnephew (Reviews Here)
https://codereview.chromium.org/2301653002/diff/1/tools/perf/page_sets/idle_after_loading_stories.py File tools/perf/page_sets/idle_after_loading_stories.py (right): https://codereview.chromium.org/2301653002/diff/1/tools/perf/page_sets/idle_after_loading_stories.py#newcode23 tools/perf/page_sets/idle_after_loading_stories.py:23: def __init__(self, wait_in_seconds=0): On 2016/08/31 20:51:24, erikchen wrote: > ...
4 years, 3 months ago (2016-08-31 20:59:13 UTC) #5
nednguyen
lgtm since Erik is happy
4 years, 3 months ago (2016-08-31 22:13:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301653002/20001
4 years, 3 months ago (2016-08-31 22:18:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/249514)
4 years, 3 months ago (2016-08-31 23:25:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301653002/20001
4 years, 3 months ago (2016-08-31 23:30:26 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 01:18:26 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 01:20:16 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6380c710d7ee2d6739e563d2957fc7475d663f70
Cr-Commit-Position: refs/heads/master@{#415832}

Powered by Google App Engine
This is Rietveld 408576698