chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java - Issue 2301633002: Refactor Vr activity into ChromeTabbedActivity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Issue 2301633002: Refactor Vr activity into ChromeTabbedActivity. (Closed)

Patch Set: Address comments and rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/VrActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

index c902e47743f32bc30345d9fcfc18eb2b035c81f1..48cf807f3611bb413fcd134a4bc4b75582e69f7c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

@@ -176,6 +176,9 @@ public class AppMenuPropertiesDelegate {

// Only display reader mode settings menu option if the current page is in reader mode.

menu.findItem(R.id.reader_mode_prefs_id)

.setVisible(DomDistillerUrlUtils.isDistilledPage(currentTab.getUrl()));

+ // Only display the Enter VR button if VR Shell is enabled.

+ menu.findItem(R.id.enter_vr_id).setVisible(mActivity.isVrShellEnabled());

}

if (isOverviewMenu) {