Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2301633002: Refactor Vr activity into ChromeTabbedActivity. (Closed)
Patch Set: Address comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.annotation.TargetApi; 8 import android.annotation.TargetApi;
9 import android.app.Activity; 9 import android.app.Activity;
10 import android.app.SearchManager; 10 import android.app.SearchManager;
(...skipping 1613 matching lines...) Expand 10 before | Expand all | Expand 10 after
1624 HelpAndFeedback.getInstance(this) 1624 HelpAndFeedback.getInstance(this)
1625 .show(this, helpContextId, currentTab.getProfile(), currentT ab.getUrl()); 1625 .show(this, helpContextId, currentTab.getProfile(), currentT ab.getUrl());
1626 RecordUserAction.record("MobileMenuFeedback"); 1626 RecordUserAction.record("MobileMenuFeedback");
1627 } else { 1627 } else {
1628 return false; 1628 return false;
1629 } 1629 }
1630 return true; 1630 return true;
1631 } 1631 }
1632 1632
1633 /** 1633 /**
1634 * Tests if VR Shell (the mode displaying browser UI and tab contents in VR) is currently
1635 * enabled.
1636 */
1637 public boolean isVrShellEnabled() {
1638 return false;
1639 }
1640
1641 /**
1634 * Add a view to the set of views that obscure the content of all tabs for 1642 * Add a view to the set of views that obscure the content of all tabs for
1635 * accessibility. As long as this set is nonempty, all tabs should be 1643 * accessibility. As long as this set is nonempty, all tabs should be
1636 * hidden from the accessibility tree. 1644 * hidden from the accessibility tree.
1637 * 1645 *
1638 * @param view The view that obscures the contents of all tabs. 1646 * @param view The view that obscures the contents of all tabs.
1639 */ 1647 */
1640 public void addViewObscuringAllTabs(View view) { 1648 public void addViewObscuringAllTabs(View view) {
1641 mViewsObscuringAllTabs.add(view); 1649 mViewsObscuringAllTabs.add(view);
1642 1650
1643 Tab tab = getActivityTab(); 1651 Tab tab = getActivityTab();
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
1822 "Android.MultiWindowMode.IsTabletScreenWidthBelow600", 1830 "Android.MultiWindowMode.IsTabletScreenWidthBelow600",
1823 mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP); 1831 mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP);
1824 1832
1825 if (mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP) { 1833 if (mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP) {
1826 RecordHistogram.recordLinearCountHistogram( 1834 RecordHistogram.recordLinearCountHistogram(
1827 "Android.MultiWindowMode.TabletScreenWidth", mScreenWidthDp, 1, 1835 "Android.MultiWindowMode.TabletScreenWidth", mScreenWidthDp, 1,
1828 DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP, 50); 1836 DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP, 50);
1829 } 1837 }
1830 } 1838 }
1831 } 1839 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698