Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2301633002: Refactor Vr activity into ChromeTabbedActivity. (Closed)
Patch Set: Address comments and rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.annotation.TargetApi; 8 import android.annotation.TargetApi;
9 import android.app.Activity; 9 import android.app.Activity;
10 import android.app.SearchManager; 10 import android.app.SearchManager;
(...skipping 1611 matching lines...) Expand 10 before | Expand all | Expand 10 after
1622 HelpAndFeedback.getInstance(this) 1622 HelpAndFeedback.getInstance(this)
1623 .show(this, helpContextId, currentTab.getProfile(), currentT ab.getUrl()); 1623 .show(this, helpContextId, currentTab.getProfile(), currentT ab.getUrl());
1624 RecordUserAction.record("MobileMenuFeedback"); 1624 RecordUserAction.record("MobileMenuFeedback");
1625 } else { 1625 } else {
1626 return false; 1626 return false;
1627 } 1627 }
1628 return true; 1628 return true;
1629 } 1629 }
1630 1630
1631 /** 1631 /**
1632 * Tests if VR Shell (the mode displaying browser UI and tab contents in VR) is currently
1633 * enabled.
1634 */
1635 public boolean isVrShellEnabled() {
1636 return false;
1637 }
1638
1639 /**
1632 * Add a view to the set of views that obscure the content of all tabs for 1640 * Add a view to the set of views that obscure the content of all tabs for
1633 * accessibility. As long as this set is nonempty, all tabs should be 1641 * accessibility. As long as this set is nonempty, all tabs should be
1634 * hidden from the accessibility tree. 1642 * hidden from the accessibility tree.
1635 * 1643 *
1636 * @param view The view that obscures the contents of all tabs. 1644 * @param view The view that obscures the contents of all tabs.
1637 */ 1645 */
1638 public void addViewObscuringAllTabs(View view) { 1646 public void addViewObscuringAllTabs(View view) {
1639 mViewsObscuringAllTabs.add(view); 1647 mViewsObscuringAllTabs.add(view);
1640 1648
1641 Tab tab = getActivityTab(); 1649 Tab tab = getActivityTab();
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
1820 "Android.MultiWindowMode.IsTabletScreenWidthBelow600", 1828 "Android.MultiWindowMode.IsTabletScreenWidthBelow600",
1821 mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP); 1829 mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP);
1822 1830
1823 if (mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP) { 1831 if (mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP) {
1824 RecordHistogram.recordLinearCountHistogram( 1832 RecordHistogram.recordLinearCountHistogram(
1825 "Android.MultiWindowMode.TabletScreenWidth", mScreenWidthDp, 1, 1833 "Android.MultiWindowMode.TabletScreenWidth", mScreenWidthDp, 1,
1826 DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP, 50); 1834 DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP, 50);
1827 } 1835 }
1828 } 1836 }
1829 } 1837 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698