Use DownloadManager to initiate downloads from PluginInstaller.

Use DownloadManager to initiate downloads from PluginInstaller.

PluginInstaller was invoking ResourceDispatcherHost::BeginDownload
directly to initiate downloads. This CL changes the initiation path to
use DownloadManager instead. DM already lives on the UI thread and
implements the logic needed to construct the URLRequest for the download
and invoke RDH on the IO thread.

Using DownloadManager for initiating downloads from the UI thread
reduces code duplication and decreases the callers of
ResourceDispatcherHost::BeginDownload. This removes one more obstacle in
the way of decoupling programmatic downloads from
ResourceDispatcherHost.

BUG=7648
BUG=225901
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265754

[asanka, 2014-04-09 18:00:06]

bauerb: Could you take a look? The plugin_installer_unittests weren't referenced
in a gypi file and the tests in it were stale.

[Bernhard Bauer, 2014-04-10 10:26:40]

https://codereview.chromium.org/230163002/diff/1/chrome/browser/plugins/plugi...
File chrome/browser/plugins/plugin_installer_unittest.cc (left):

https://codereview.chromium.org/230163002/diff/1/chrome/browser/plugins/plugi...
chrome/browser/plugins/plugin_installer_unittest.cc:25:
TEST(PluginInstallerTest, SecurityStatus) {
I'd be interested in getting this working again. Does it fail or not compile at
all? Can you just disable the test and add a TODO(bauerb) to get it working
again?

https://codereview.chromium.org/230163002/diff/1/chrome/browser/plugins/plugi...
File chrome/browser/plugins/plugin_installer_unittest.cc (right):

https://codereview.chromium.org/230163002/diff/1/chrome/browser/plugins/plugi...
chrome/browser/plugins/plugin_installer_unittest.cc:91: namespace {
Nit: move this to the top of the file?

[asanka, 2014-04-18 18:07:49]

Sorry about the delay.

https://codereview.chromium.org/230163002/diff/1/chrome/browser/plugins/plugi...
File chrome/browser/plugins/plugin_installer_unittest.cc (left):

https://codereview.chromium.org/230163002/diff/1/chrome/browser/plugins/plugi...
chrome/browser/plugins/plugin_installer_unittest.cc:25:
TEST(PluginInstallerTest, SecurityStatus) {
On 2014/04/10 10:26:40, Bernhard Bauer wrote:
> I'd be interested in getting this working again. Does it fail or not compile
at
> all? Can you just disable the test and add a TODO(bauerb) to get it working
> again?

The test didn't compile. Also GetSecurityStatus() has been moved to
PluginMetadata and the tests have been moved to plugin_metadata_unittest.cc.

https://codereview.chromium.org/230163002/diff/1/chrome/browser/plugins/plugi...
File chrome/browser/plugins/plugin_installer_unittest.cc (right):

https://codereview.chromium.org/230163002/diff/1/chrome/browser/plugins/plugi...
chrome/browser/plugins/plugin_installer_unittest.cc:91: namespace {
On 2014/04/10 10:26:40, Bernhard Bauer wrote:
> Nit: move this to the top of the file?

Done.

[Bernhard Bauer, 2014-04-23 08:33:25]

LGTM

https://codereview.chromium.org/230163002/diff/1/chrome/browser/plugins/plugi...
File chrome/browser/plugins/plugin_installer_unittest.cc (left):

https://codereview.chromium.org/230163002/diff/1/chrome/browser/plugins/plugi...
chrome/browser/plugins/plugin_installer_unittest.cc:25:
TEST(PluginInstallerTest, SecurityStatus) {
On 2014/04/18 18:07:49, asanka wrote:
> On 2014/04/10 10:26:40, Bernhard Bauer wrote:
> > I'd be interested in getting this working again. Does it fail or not compile
> at
> > all? Can you just disable the test and add a TODO(bauerb) to get it working
> > again?
> 
> The test didn't compile. Also GetSecurityStatus() has been moved to
> PluginMetadata and the tests have been moved to plugin_metadata_unittest.cc.

Oh, so the test in here was most likely left over from a refactoring.

[asanka, 2014-04-23 20:10:46]

The CQ bit was checked by asanka@chromium.org

[commit-bot: I haz the power, 2014-04-23 20:12:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/230163002/20001

[commit-bot: I haz the power, 2014-04-23 22:15:16]

Change committed as 265754