Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2301523008: Fix Windows build warning (Closed)

Created:
4 years, 3 months ago by qiankun
Modified:
4 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Windows build warning When building midi_manager_winrt.cc, following warning is raised: warning C4467: usage of ATL attributes is deprecated. Attributed ATL code has been deprecated. New code style can be found in https://msdn.microsoft.com/en-us/library/mt723604.aspx. BUG=512433 Committed: https://crrev.com/5c8d5551030136f5acb4a10dde621f4edf724c6f Cr-Commit-Position: refs/heads/master@{#416416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/midi/midi_manager_winrt.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
qiankun
PTAL.
4 years, 3 months ago (2016-09-02 17:33:01 UTC) #2
Takashi Toyoshima
lgtm (assuming first bot failures were infra issues)
4 years, 3 months ago (2016-09-02 17:59:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301523008/1
4 years, 3 months ago (2016-09-03 00:39:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-03 00:44:27 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-03 00:46:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c8d5551030136f5acb4a10dde621f4edf724c6f
Cr-Commit-Position: refs/heads/master@{#416416}

Powered by Google App Engine
This is Rietveld 408576698