telemetry/telemetry/internal/platform/tracing_controller_backend.py - Issue 2301523007: Add trace events for some of telemetry internal functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/tracing_controller_backend.py

Issue 2301523007: Add trace events for some of telemetry internal functions (Closed)

Patch Set: Address Petr's nit Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py ('k') | telemetry/telemetry/page/legacy_page_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/platform/tracing_controller_backend.py

diff --git a/telemetry/telemetry/internal/platform/tracing_controller_backend.py b/telemetry/telemetry/internal/platform/tracing_controller_backend.py

index 19c06e53022455bf12393a80ad37680114989791..7f805e8b13f079ce439b94d9035e4d907d51d2b6 100644

--- a/telemetry/telemetry/internal/platform/tracing_controller_backend.py

+++ b/telemetry/telemetry/internal/platform/tracing_controller_backend.py

@@ -195,8 +195,12 @@ class TracingControllerBackend(object):

for agent in self._active_agents_instances:

if agent.SupportsExplicitClockSync():

sync_id = self._GenerateClockSyncId()

- agent.RecordClockSyncMarker(sync_id,

- self._RecordIssuerClockSyncMarker)

+ with trace_event.trace(

+ 'RecordClockSyncMarker',

+ agent=str(agent.__class__.__name__),

+ sync_id=sync_id):

+ agent.RecordClockSyncMarker(sync_id,

+ self._RecordIssuerClockSyncMarker)

def IsChromeTracingSupported(self):

return chrome_tracing_agent.ChromeTracingAgent.IsSupported(