Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: telemetry/telemetry/benchmark_runner.py

Issue 2301523007: Add trace events for some of telemetry internal functions (Closed)
Patch Set: Address Petr's nit Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « firefighter/default/tracing/tracing ('k') | telemetry/telemetry/core/network_controller.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/benchmark_runner.py
diff --git a/telemetry/telemetry/benchmark_runner.py b/telemetry/telemetry/benchmark_runner.py
index d7116194848c9cf51aebd1528703fcae02ce0077..598bc5315e1937707c3cb2461f00a39586ab008f 100644
--- a/telemetry/telemetry/benchmark_runner.py
+++ b/telemetry/telemetry/benchmark_runner.py
@@ -24,6 +24,7 @@ from telemetry.internal.util import command_line
from telemetry.internal.util import ps_util
from telemetry.util import matching
+
# Right now, we only have one of each of our power perf bots. This means that
# all eligible Telemetry benchmarks are run unsharded, which results in very
# long (12h) cycle times. We'd like to reduce the number of tests that we run
@@ -37,6 +38,7 @@ GOOD_POWER_PERF_BOT_WHITELIST = [
"Mac Power Low-End Perf"
]
+
DEFAULT_LOG_FORMAT = (
'(%(levelname)s) %(asctime)s %(module)s.%(funcName)s:%(lineno)d '
'%(message)s')
@@ -375,7 +377,7 @@ def _GetJsonBenchmarkList(possible_browser, possible_reference_browser,
def main(environment, extra_commands=None, **log_config_kwargs):
- # the log level is set in browser_options
+ # The log level is set in browser_options.
log_config_kwargs.pop('level', None)
log_config_kwargs.setdefault('format', DEFAULT_LOG_FORMAT)
logging.basicConfig(**log_config_kwargs)
« no previous file with comments | « firefighter/default/tracing/tracing ('k') | telemetry/telemetry/core/network_controller.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698