Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: media/midi/BUILD.gn

Issue 2301513002: Remove RuntimeObject.lib dependency in Windows 10 Web MIDI backend (Closed)
Patch Set: move LoadLibrary() to InitializeOnComThread() Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/midi/midi_manager_winrt.cc » ('j') | media/midi/midi_manager_winrt.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/BUILD.gn
diff --git a/media/midi/BUILD.gn b/media/midi/BUILD.gn
index 61ce3a0705a4dd649607a8bdde9f7059faacd33a..f3758563f3b65f7ff5e2d29154b3dc5e4e4710f1 100644
--- a/media/midi/BUILD.gn
+++ b/media/midi/BUILD.gn
@@ -137,19 +137,13 @@ component("midi") {
}
if (is_win) {
- deps += [ "//device/usb" ]
-
if (midi_use_winrt) {
sources += [
"midi_manager_winrt.cc",
"midi_manager_winrt.h",
]
-
- # TODO(crbug.com/642602): This adds runtime dependency to libraries that
- # may not be available on Windows 7. Should eventually remove this and
- # load functions dynamically (as in base::win::IsWindows10TabletMode).
- libs += [ "runtimeobject.lib" ]
} else {
+ deps += [ "//device/usb" ]
sources += [
"midi_manager_win.cc",
"midi_manager_win.h",
« no previous file with comments | « no previous file | media/midi/midi_manager_winrt.cc » ('j') | media/midi/midi_manager_winrt.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698