Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: media/midi/BUILD.gn

Issue 2301513002: Remove RuntimeObject.lib dependency in Windows 10 Web MIDI backend (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | media/midi/midi_manager_winrt.cc » ('j') | media/midi/midi_manager_winrt.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/features.gni") 6 import("//build/config/features.gni")
7 import("//build/config/ui.gni") 7 import("//build/config/ui.gni")
8 import("//media/media_options.gni") 8 import("//media/media_options.gni")
9 import("//media/midi/midi_options.gni") 9 import("//media/midi/midi_options.gni")
10 import("//testing/test.gni") 10 import("//testing/test.gni")
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 130
131 if (is_mac) { 131 if (is_mac) {
132 libs += [ 132 libs += [
133 "CoreAudio.framework", 133 "CoreAudio.framework",
134 "CoreFoundation.framework", 134 "CoreFoundation.framework",
135 "CoreMIDI.framework", 135 "CoreMIDI.framework",
136 ] 136 ]
137 } 137 }
138 138
139 if (is_win) { 139 if (is_win) {
140 deps += [ "//device/usb" ]
141
142 if (midi_use_winrt) { 140 if (midi_use_winrt) {
143 sources += [ 141 sources += [
144 "midi_manager_winrt.cc", 142 "midi_manager_winrt.cc",
145 "midi_manager_winrt.h", 143 "midi_manager_winrt.h",
146 ] 144 ]
147
148 # TODO(crbug.com/642602): This adds runtime dependency to libraries that
149 # may not be available on Windows 7. Should eventually remove this and
150 # load functions dynamically (as in base::win::IsWindows10TabletMode).
151 libs += [ "runtimeobject.lib" ]
152 } else { 145 } else {
146 deps += [ "//device/usb" ]
153 sources += [ 147 sources += [
154 "midi_manager_win.cc", 148 "midi_manager_win.cc",
155 "midi_manager_win.h", 149 "midi_manager_win.h",
156 ] 150 ]
157 } 151 }
158 } 152 }
159 153
160 if (use_alsa && use_udev) { 154 if (use_alsa && use_udev) {
161 deps += [ 155 deps += [
162 "//crypto", 156 "//crypto",
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 sources += [ "midi_manager_alsa_unittest.cc" ] 202 sources += [ "midi_manager_alsa_unittest.cc" ]
209 } 203 }
210 204
211 if (use_x11) { 205 if (use_x11) {
212 deps += [ "//tools/xdisplaycheck" ] 206 deps += [ "//tools/xdisplaycheck" ]
213 } 207 }
214 208
215 # This target should not require the Chrome executable to run. 209 # This target should not require the Chrome executable to run.
216 assert_no_deps = [ "//chrome" ] 210 assert_no_deps = [ "//chrome" ]
217 } 211 }
OLDNEW
« no previous file with comments | « no previous file | media/midi/midi_manager_winrt.cc » ('j') | media/midi/midi_manager_winrt.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698