Issue 2301453003: Inline chrome/renderer sources into the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2301453003: Inline chrome/renderer sources into the GN build. (Closed)

Created:
4 years, 3 months ago by brettw

Modified:
4 years, 3 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Inline chrome/renderer sources into the GN build. Delete chrome/chrome_renderer.gypi. TBR=dpranke@chromium.org Committed: https://crrev.com/528e577e7212847f4b1104a0dc4a29f918e88c51 Cr-Commit-Position: refs/heads/master@{#415765}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -409 lines)			Patch
	D	chrome/chrome_renderer.gypi	View		1 chunk	+0 lines, -380 lines	0 comments	Download
	M	chrome/renderer/BUILD.gn	View		6 chunks	+213 lines, -29 lines	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301453003/1

4 years, 3 months ago (2016-08-31 20:29:42 UTC) #2

commit-bot: I haz the power

4 years, 3 months ago (2016-08-31 21:52:36 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/528e577e7212847f4b1104a0dc4a29f918e88c51
Cr-Commit-Position: refs/heads/master@{#415765}