Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: net/quic/chromium/quic_chromium_client_session.cc

Issue 2301453002: Quic use reduced PING timeout when previous connection times out with open streams (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/quic_chromium_client_session.cc
diff --git a/net/quic/chromium/quic_chromium_client_session.cc b/net/quic/chromium/quic_chromium_client_session.cc
index 06e0a5136e35bbfeb8e4796fe3a94c6bc31fd73f..f9c3638bdacbb7ed1c81cff218a09085900a072a 100644
--- a/net/quic/chromium/quic_chromium_client_session.cc
+++ b/net/quic/chromium/quic_chromium_client_session.cc
@@ -876,6 +876,11 @@ void QuicChromiumClientSession::OnConnectionClosed(
UMA_HISTOGRAM_COUNTS(
"Net.QuicSession.ConnectionClose.NumOpenStreams.TimedOut",
GetNumOpenOutgoingStreams());
+ // If the connection times out with open stream, notify the factory to use
+ // reduced ping timeouts.
+ if (GetNumOpenOutgoingStreams() > 0 && stream_factory_) {
+ stream_factory_->set_reduced_ping_timeout();
Ryan Hamilton 2016/09/01 16:36:14 nit: I'd probably be inclined to call stream_facto
Zhongyi Shi 2016/09/01 18:58:29 Done.
+ }
if (IsCryptoHandshakeConfirmed()) {
if (GetNumOpenOutgoingStreams() > 0) {
disabled_reason_ = QUIC_DISABLED_TIMEOUT_WITH_OPEN_STREAMS;

Powered by Google App Engine
This is Rietveld 408576698