Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2301423002: includes: Make ast.h not need isolate.h any more. (Closed)

Created:
4 years, 3 months ago by marja
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

includes: Make ast.h not need isolate.h any more. Also remove other unnecessary includes from ast.h and dependencies. BUG=v8:5294 Committed: https://crrev.com/9c888dffda4bff420ec3ef21e623aa4e5054d1c3 Cr-Commit-Position: refs/heads/master@{#39155}

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -35 lines) Patch
M src/asmjs/asm-wasm-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast/ast.h View 1 2 4 chunks +1 line, -12 lines 0 comments Download
M src/ast/ast-expression-rewriter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ast/ast-numbering.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/ast/ast-traversal-visitor.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/ast/modules.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/ast/modules.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ast/prettyprinter.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/crankshaft/typing.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/debug/liveedit.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M src/parsing/rewriter.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 38 (21 generated)
marja
adamk, ptal (Sadly, this doesn't solve the problem in the bug (the problem is the ...
4 years, 3 months ago (2016-09-02 12:32:50 UTC) #3
adamk
lgtm
4 years, 3 months ago (2016-09-02 17:13:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301423002/20001
4 years, 3 months ago (2016-09-05 07:42:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/23879) v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-05 07:43:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301423002/60001
4 years, 3 months ago (2016-09-05 09:08:30 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23260)
4 years, 3 months ago (2016-09-05 09:12:20 UTC) #18
Michael Starzinger
LGTM.
4 years, 3 months ago (2016-09-05 09:19:17 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301423002/60001
4 years, 3 months ago (2016-09-05 09:21:40 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23263)
4 years, 3 months ago (2016-09-05 09:25:30 UTC) #24
Benedikt Meurer
LGTM (rubberstamp)
4 years, 3 months ago (2016-09-05 09:49:31 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301423002/60001
4 years, 3 months ago (2016-09-05 09:50:47 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23267)
4 years, 3 months ago (2016-09-05 09:55:17 UTC) #30
titzer
On 2016/09/05 09:55:17, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-05 10:39:30 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301423002/60001
4 years, 3 months ago (2016-09-05 10:39:57 UTC) #33
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-09-05 10:53:12 UTC) #35
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/9c888dffda4bff420ec3ef21e623aa4e5054d1c3 Cr-Commit-Position: refs/heads/master@{#39155}
4 years, 3 months ago (2016-09-05 10:53:36 UTC) #37
Michael Achenbach
4 years, 3 months ago (2016-09-05 11:48:35 UTC) #38
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2305373002/ by machenbach@chromium.org.

The reason for reverting is: Breaks gc stress:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/....

Powered by Google App Engine
This is Rietveld 408576698