predictors: Clean up after removing STLDeleteContainerPairFirstPointers

chrome/browser/predictors/resource_prefetcher_unittest.cc

Index: chrome/browser/predictors/resource_prefetcher_unittest.cc
diff --git a/chrome/browser/predictors/resource_prefetcher_unittest.cc b/chrome/browser/predictors/resource_prefetcher_unittest.cc
index e1ba98d6d426196d21057d43d7ad66dea3485f21..345b664ecd1de892f6a843b9600a5c75a8a7cfcc 100644
--- a/chrome/browser/predictors/resource_prefetcher_unittest.cc
+++ b/chrome/browser/predictors/resource_prefetcher_unittest.cc
@@ -106,16 +106,14 @@ class ResourcePrefetcherTest : public testing::Test {
   net::URLRequest* GetInFlightRequest(const std::string& url_str) {
     GURL url(url_str);
 
-    for (auto it = prefetcher_->request_queue_.begin();
-         it != prefetcher_->request_queue_.end(); ++it) {
-      EXPECT_NE((*it)->resource_url, url);
+    for (auto* request : prefetcher_->request_queue_) {
+      EXPECT_NE(request->resource_url, url);
     }
-    for (auto it = prefetcher_->inflight_requests_.begin();
-         it != prefetcher_->inflight_requests_.end(); ++it) {
-      if (it->first->original_url() == url)
-        return it->first;
+    for (const auto& it : prefetcher_->inflight_requests_) {

[Benoit L, 2016/09/02 10:44:12]

nit: "it" is a bit misleading here, I usually use p or something else. Which is
also not really explicit, but it doesn't imply that it's an iterator.

[pasko, 2016/09/02 10:51:10]

Agreed. Changed to key_value, still lgty?

+      if (it.first->original_url() == url)
+        return it.first;
     }
-    EXPECT_TRUE(false) << "Inflight request not found: " << url_str;
+    EXPECT_TRUE(false) << "In flight request not found: " << url_str;
     return NULL;
   }