predictors: Clean up after removing STLDeleteContainerPairFirstPointers

predictors: Clean up after removing STLDeleteContainerPairFirstPointers

Addressing my own nits expressed in review of:
https://codereview.chromium.org/2293153002/
    (Remove stl_util's STLDeleteContainerPairFirstPointers.)

BUG=555865
Committed: https://crrev.com/b794e6238b33f669e01af980039b563346bf3d96
Cr-Commit-Position: refs/heads/master@{#416239}

[pasko, 2016-09-02 10:37:08]

The CQ bit was checked by pasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 10:37:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pasko, 2016-09-02 10:38:22]

Description was changed from

==========
predictors: Clean up after removing STLDeleteContainerPairFirstPointers

Addressing my own nits expressed in review of:
https://codereview.chromium.org/2293153002/
    (Remove stl_util's STLDeleteContainerPairFirstPointers.)

BUG=555865
==========

to

==========
predictors: Clean up after removing STLDeleteContainerPairFirstPointers

Addressing my own nits expressed in review of:
https://codereview.chromium.org/2293153002/
    (Remove stl_util's STLDeleteContainerPairFirstPointers.)

BUG=555865
==========

[pasko, 2016-09-02 10:38:22]

pasko@chromium.org changed reviewers:
+ lizeb@chromium.org

[Benoit L, 2016-09-02 10:44:12]

LGTM

https://codereview.chromium.org/2301403002/diff/1/chrome/browser/predictors/r...
File chrome/browser/predictors/resource_prefetcher_unittest.cc (right):

https://codereview.chromium.org/2301403002/diff/1/chrome/browser/predictors/r...
chrome/browser/predictors/resource_prefetcher_unittest.cc:112: for (const auto&
it : prefetcher_->inflight_requests_) {
nit: "it" is a bit misleading here, I usually use p or something else. Which is
also not really explicit, but it doesn't imply that it's an iterator.

[pasko, 2016-09-02 10:51:11]

https://codereview.chromium.org/2301403002/diff/1/chrome/browser/predictors/r...
File chrome/browser/predictors/resource_prefetcher_unittest.cc (right):

https://codereview.chromium.org/2301403002/diff/1/chrome/browser/predictors/r...
chrome/browser/predictors/resource_prefetcher_unittest.cc:112: for (const auto&
it : prefetcher_->inflight_requests_) {
On 2016/09/02 10:44:12, Benoit L wrote:
> nit: "it" is a bit misleading here, I usually use p or something else. Which
is
> also not really explicit, but it doesn't imply that it's an iterator.

Agreed. Changed to key_value, still lgty?

[Benoit L, 2016-09-02 10:55:02]

On 2016/09/02 10:51:11, pasko wrote:
>
https://codereview.chromium.org/2301403002/diff/1/chrome/browser/predictors/r...
> File chrome/browser/predictors/resource_prefetcher_unittest.cc (right):
> 
>
https://codereview.chromium.org/2301403002/diff/1/chrome/browser/predictors/r...
> chrome/browser/predictors/resource_prefetcher_unittest.cc:112: for (const
auto&
> it : prefetcher_->inflight_requests_) {
> On 2016/09/02 10:44:12, Benoit L wrote:
> > nit: "it" is a bit misleading here, I usually use p or something else. Which
> is
> > also not really explicit, but it doesn't imply that it's an iterator.
> 
> Agreed. Changed to key_value, still lgty?

👍

[pasko, 2016-09-02 10:57:35]

The CQ bit was checked by pasko@chromium.org

[pasko, 2016-09-02 10:57:35]

The patchset sent to the CQ was uploaded after l-g-t-m from lizeb@chromium.org
Link to the patchset: https://codereview.chromium.org/2301403002/#ps20001
(title: "it -> key_value")

[commit-bot: I haz the power, 2016-09-02 10:58:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 11:38:51]

Description was changed from

==========
predictors: Clean up after removing STLDeleteContainerPairFirstPointers

Addressing my own nits expressed in review of:
https://codereview.chromium.org/2293153002/
    (Remove stl_util's STLDeleteContainerPairFirstPointers.)

BUG=555865
==========

to

==========
predictors: Clean up after removing STLDeleteContainerPairFirstPointers

Addressing my own nits expressed in review of:
https://codereview.chromium.org/2293153002/
    (Remove stl_util's STLDeleteContainerPairFirstPointers.)

BUG=555865
==========

[commit-bot: I haz the power, 2016-09-02 11:38:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-02 11:40:26]

Description was changed from

==========
predictors: Clean up after removing STLDeleteContainerPairFirstPointers

Addressing my own nits expressed in review of:
https://codereview.chromium.org/2293153002/
    (Remove stl_util's STLDeleteContainerPairFirstPointers.)

BUG=555865
==========

to

==========
predictors: Clean up after removing STLDeleteContainerPairFirstPointers

Addressing my own nits expressed in review of:
https://codereview.chromium.org/2293153002/
    (Remove stl_util's STLDeleteContainerPairFirstPointers.)

BUG=555865

Committed: https://crrev.com/b794e6238b33f669e01af980039b563346bf3d96
Cr-Commit-Position: refs/heads/master@{#416239}
==========

[commit-bot: I haz the power, 2016-09-02 11:40:27]

Patchset 2 (id:??) landed as
https://crrev.com/b794e6238b33f669e01af980039b563346bf3d96
Cr-Commit-Position: refs/heads/master@{#416239}