Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: media/base/audio_decoder_config.cc

Issue 23014009: media: Opus support for WebM in Media Source (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments. using base::TimeDelta for relevant fields. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/audio_decoder_config.cc
diff --git a/media/base/audio_decoder_config.cc b/media/base/audio_decoder_config.cc
index 38db05d3a54e1a7106da2d49a74b7085bdd5a05e..c1c0aa190ebce312dbe7b0e1650887992c5bc3af 100644
--- a/media/base/audio_decoder_config.cc
+++ b/media/base/audio_decoder_config.cc
@@ -6,6 +6,7 @@
#include "base/logging.h"
#include "base/metrics/histogram.h"
+#include "base/time/time.h"
#include "media/audio/sample_rates.h"
#include "media/base/limits.h"
#include "media/base/sample_format.h"
@@ -19,7 +20,9 @@ AudioDecoderConfig::AudioDecoderConfig()
channel_layout_(CHANNEL_LAYOUT_UNSUPPORTED),
samples_per_second_(0),
bytes_per_frame_(0),
- is_encrypted_(false) {
+ is_encrypted_(false),
+ seek_pre_roll_(base::TimeDelta()),
acolwell GONE FROM CHROMIUM 2013/09/03 20:14:01 nit: not needed here and the line below.
vignesh 2013/09/03 22:43:03 Done.
+ codec_delay_(base::TimeDelta()) {
}
AudioDecoderConfig::AudioDecoderConfig(AudioCodec codec,
@@ -30,7 +33,8 @@ AudioDecoderConfig::AudioDecoderConfig(AudioCodec codec,
size_t extra_data_size,
bool is_encrypted) {
Initialize(codec, sample_format, channel_layout, samples_per_second,
- extra_data, extra_data_size, is_encrypted, true);
+ extra_data, extra_data_size, is_encrypted, true,
+ base::TimeDelta(), base::TimeDelta());
}
void AudioDecoderConfig::Initialize(AudioCodec codec,
@@ -40,7 +44,9 @@ void AudioDecoderConfig::Initialize(AudioCodec codec,
const uint8* extra_data,
size_t extra_data_size,
bool is_encrypted,
- bool record_stats) {
+ bool record_stats,
+ base::TimeDelta seek_pre_roll,
+ base::TimeDelta codec_delay) {
CHECK((extra_data_size != 0) == (extra_data != NULL));
if (record_stats) {
@@ -66,6 +72,8 @@ void AudioDecoderConfig::Initialize(AudioCodec codec,
bytes_per_channel_ = SampleFormatToBytesPerChannel(sample_format);
extra_data_.assign(extra_data, extra_data + extra_data_size);
is_encrypted_ = is_encrypted;
+ seek_pre_roll_ = seek_pre_roll;
+ codec_delay_ = codec_delay;
int channels = ChannelLayoutToChannelCount(channel_layout_);
bytes_per_frame_ = channels * bytes_per_channel_;
@@ -92,7 +100,9 @@ bool AudioDecoderConfig::Matches(const AudioDecoderConfig& config) const {
(!extra_data() || !memcmp(extra_data(), config.extra_data(),
extra_data_size())) &&
(is_encrypted() == config.is_encrypted()) &&
- (sample_format() == config.sample_format()));
+ (sample_format() == config.sample_format()) &&
+ (seek_pre_roll() == config.seek_pre_roll()) &&
+ (codec_delay() == config.codec_delay()));
}
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698