|
|
Created:
4 years, 3 months ago by Franzi Modified:
4 years, 3 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[api] Add tests that document get callback behavior.
BUG=
Committed: https://crrev.com/26720293332fdf36d243f75faa1178174215139c
Cr-Commit-Position: refs/heads/master@{#39208}
Patch Set 1 #Patch Set 2 : Minor fixes. #Messages
Total messages: 24 (19 generated)
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [api] Add test that documents get callback behavior. We call into the get callback when defineProperty() with an accessor descriptor is called. This test documents that behavior. BUG= ========== to ========== [api] Add tests that document get callback behavior. BUG= ==========
franzih@chromium.org changed reviewers: + jochen@chromium.org
Hi Jochen, I'd like to add these test cases so we're aware if we modify the behavior of get and define property callbacks. PTAL. Thanks, Franzi
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by franzih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [api] Add tests that document get callback behavior. BUG= ========== to ========== [api] Add tests that document get callback behavior. BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [api] Add tests that document get callback behavior. BUG= ========== to ========== [api] Add tests that document get callback behavior. BUG= Committed: https://crrev.com/26720293332fdf36d243f75faa1178174215139c Cr-Commit-Position: refs/heads/master@{#39208} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/26720293332fdf36d243f75faa1178174215139c Cr-Commit-Position: refs/heads/master@{#39208} |