Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2301393002: [api] Add test that documents get callback behavior. (Closed)

Created:
4 years, 3 months ago by Franzi
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Add tests that document get callback behavior. BUG= Committed: https://crrev.com/26720293332fdf36d243f75faa1178174215139c Cr-Commit-Position: refs/heads/master@{#39208}

Patch Set 1 #

Patch Set 2 : Minor fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -0 lines) Patch
M test/cctest/test-api-interceptors.cc View 1 1 chunk +87 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (19 generated)
Franzi
Hi Jochen, I'd like to add these test cases so we're aware if we modify ...
4 years, 3 months ago (2016-09-06 12:30:42 UTC) #15
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-06 13:26:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301393002/60001
4 years, 3 months ago (2016-09-06 13:33:36 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 3 months ago (2016-09-06 13:35:52 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 13:37:02 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26720293332fdf36d243f75faa1178174215139c
Cr-Commit-Position: refs/heads/master@{#39208}

Powered by Google App Engine
This is Rietveld 408576698