Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Side by Side Diff: tools/perf/benchmarks/memory_infra.py

Issue 2301383002: [tools/perf] Explicitly disable state tear down on some benchmarks (Closed)
Patch Set: petr's comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from core import perf_benchmark 7 from core import perf_benchmark
8 8
9 from telemetry import benchmark 9 from telemetry import benchmark
10 from telemetry.timeline import chrome_trace_category_filter 10 from telemetry.timeline import chrome_trace_category_filter
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 Chrome on Android. 55 Chrome on Android.
56 """ 56 """
57 page_set = page_sets.MemoryTop10Mobile 57 page_set = page_sets.MemoryTop10Mobile
58 options = {'pageset_repeat': 5} 58 options = {'pageset_repeat': 5}
59 59
60 @classmethod 60 @classmethod
61 def Name(cls): 61 def Name(cls):
62 return 'memory.top_10_mobile' 62 return 'memory.top_10_mobile'
63 63
64 @classmethod 64 @classmethod
65 def ShouldTearDownStateAfterEachStoryRun(cls):
66 return False
67
68 @classmethod
65 def ShouldDisable(cls, possible_browser): 69 def ShouldDisable(cls, possible_browser):
66 # TODO(crbug.com/586148): Benchmark should not depend on DeskClock app. 70 # TODO(crbug.com/586148): Benchmark should not depend on DeskClock app.
67 return not possible_browser.platform.CanLaunchApplication( 71 return not possible_browser.platform.CanLaunchApplication(
68 'com.google.android.deskclock') 72 'com.google.android.deskclock')
69 73
70 @classmethod 74 @classmethod
71 def ValueCanBeAddedPredicate(cls, value, is_first_result): 75 def ValueCanBeAddedPredicate(cls, value, is_first_result):
72 # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard 76 # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
73 # is able to cope with the data load generated by TBMv2 metrics. 77 # is able to cope with the data load generated by TBMv2 metrics.
74 return not _IGNORED_STATS_RE.search(value.name) 78 return not _IGNORED_STATS_RE.search(value.name)
(...skipping 26 matching lines...) Expand all
101 pages on a select browser. 105 pages on a select browser.
102 """ 106 """
103 page_set = page_sets.DualBrowserStorySet 107 page_set = page_sets.DualBrowserStorySet
104 options = {'pageset_repeat': 5} 108 options = {'pageset_repeat': 5}
105 109
106 @classmethod 110 @classmethod
107 def Name(cls): 111 def Name(cls):
108 return 'memory.dual_browser_test' 112 return 'memory.dual_browser_test'
109 113
110 @classmethod 114 @classmethod
115 def ShouldTearDownStateAfterEachStoryRun(cls):
116 return False
117
118 @classmethod
111 def ValueCanBeAddedPredicate(cls, value, is_first_result): 119 def ValueCanBeAddedPredicate(cls, value, is_first_result):
112 # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard 120 # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
113 # is able to cope with the data load generated by TBMv2 metrics. 121 # is able to cope with the data load generated by TBMv2 metrics.
114 return not _IGNORED_STATS_RE.search(value.name) 122 return not _IGNORED_STATS_RE.search(value.name)
115 123
116 124
117 # Benchmark disabled by default. Force to run with --also-run-disabled-tests. 125 # Benchmark disabled by default. Force to run with --also-run-disabled-tests.
118 @benchmark.Disabled('all') 126 @benchmark.Disabled('all')
119 class LongRunningDualBrowserBenchmark(_MemoryInfra): 127 class LongRunningDualBrowserBenchmark(_MemoryInfra):
120 """Measures memory during prolonged usage of alternating browsers. 128 """Measures memory during prolonged usage of alternating browsers.
121 129
122 Same as memory.dual_browser_test, but the test is run for 60 iterations 130 Same as memory.dual_browser_test, but the test is run for 60 iterations
123 and the browser is *not* restarted between page set repeats. 131 and the browser is *not* restarted between page set repeats.
124 """ 132 """
125 page_set = page_sets.DualBrowserStorySet 133 page_set = page_sets.DualBrowserStorySet
126 options = {'pageset_repeat': 60} 134 options = {'pageset_repeat': 60}
127 135
128 @classmethod 136 @classmethod
129 def Name(cls): 137 def Name(cls):
130 return 'memory.long_running_dual_browser_test' 138 return 'memory.long_running_dual_browser_test'
131 139
132 @classmethod 140 @classmethod
141 def ShouldTearDownStateAfterEachStoryRun(cls):
142 return False
143
144 @classmethod
133 def ShouldTearDownStateAfterEachStorySetRun(cls): 145 def ShouldTearDownStateAfterEachStorySetRun(cls):
134 return False 146 return False
135 147
136 @classmethod 148 @classmethod
137 def ValueCanBeAddedPredicate(cls, value, is_first_result): 149 def ValueCanBeAddedPredicate(cls, value, is_first_result):
138 # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard 150 # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
139 # is able to cope with the data load generated by TBMv2 metrics. 151 # is able to cope with the data load generated by TBMv2 metrics.
140 return not _IGNORED_STATS_RE.search(value.name) 152 return not _IGNORED_STATS_RE.search(value.name)
141 153
142 154
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 of long running idle Gmail page """ 236 of long running idle Gmail page """
225 page_set = page_sets.LongRunningIdleGmailBackgroundPageSet 237 page_set = page_sets.LongRunningIdleGmailBackgroundPageSet
226 238
227 @classmethod 239 @classmethod
228 def Name(cls): 240 def Name(cls):
229 return 'memory.long_running_idle_gmail_background_tbmv2' 241 return 'memory.long_running_idle_gmail_background_tbmv2'
230 242
231 @classmethod 243 @classmethod
232 def ShouldDisable(cls, possible_browser): # http://crbug.com/616530 244 def ShouldDisable(cls, possible_browser): # http://crbug.com/616530
233 return cls.IsSvelte(possible_browser) 245 return cls.IsSvelte(possible_browser)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698