[tools/perf] Explicitly disable state tear down on some benchmarks

tools/perf/benchmarks/memory_infra.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from core import perf_benchmark
 
 from telemetry import benchmark
 from telemetry.timeline import chrome_trace_category_filter
@@ skipping 44 matching lines @@
   Chrome on Android.
   """
   page_set = page_sets.MemoryTop10Mobile
   options = {'pageset_repeat': 5}
 
   @classmethod
   def Name(cls):
     return 'memory.top_10_mobile'
 
   @classmethod
+  def ShouldTearDownStateAfterEachStoryRun(cls):
+    return False

[perezju, 2016/09/02 09:31:36]

I've just realized we cannot tear down the state on this benchmark since it also
measures background memory usage, and a dead browser won't be of use for that.
:(

+
+  @classmethod
   def ShouldDisable(cls, possible_browser):
     # TODO(crbug.com/586148): Benchmark should not depend on DeskClock app.
     return not possible_browser.platform.CanLaunchApplication(
         'com.google.android.deskclock')
 
   @classmethod
   def ValueCanBeAddedPredicate(cls, value, is_first_result):
     # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
     # is able to cope with the data load generated by TBMv2 metrics.
     return not _IGNORED_STATS_RE.search(value.name)
 
 
 class MemoryBenchmarkTop10MobileStress(MemoryBenchmarkTop10Mobile):
   """Run top 10 mobile page set without closing/restarting the browser.
 
   This benchmark is intended to stress-test the browser, catching memory leaks
   or possible crashes after interacting with the browser for a period of time.
   """
   page_set = page_sets.MemoryTop10MobileRealistic
 
   @classmethod
   def Name(cls):
     return 'memory.top_10_mobile_stress'
 
   @classmethod
+  def ShouldTearDownStateAfterEachStoryRun(cls):
+    return False

[petrcermak, 2016/09/02 09:40:55]

You don't need this here because the class inherits from
MemoryBenchmarkTop10Mobile.

[perezju, 2016/09/02 10:53:37]

Good catch.

+
+  @classmethod
   def ShouldTearDownStateAfterEachStorySetRun(cls):
     return False
 
 
 # Benchmark disabled by default. Force to run with --also-run-disabled-tests.
 @benchmark.Disabled('all')
 class DualBrowserBenchmark(_MemoryInfra):
   """Measures memory usage while interacting with two different browsers.
 
   The user story involves going back and forth between doing Google searches
   on a webview-based browser (a stand in for the Search app), and loading
   pages on a select browser.
   """
   page_set = page_sets.DualBrowserStorySet
   options = {'pageset_repeat': 5}
 
   @classmethod
   def Name(cls):
     return 'memory.dual_browser_test'
 
   @classmethod
+  def ShouldTearDownStateAfterEachStoryRun(cls):
+    return False
+
+  @classmethod
   def ValueCanBeAddedPredicate(cls, value, is_first_result):
     # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
     # is able to cope with the data load generated by TBMv2 metrics.
     return not _IGNORED_STATS_RE.search(value.name)
 
 
 # Benchmark disabled by default. Force to run with --also-run-disabled-tests.
 @benchmark.Disabled('all')
 class LongRunningDualBrowserBenchmark(_MemoryInfra):
   """Measures memory during prolonged usage of alternating browsers.
 
   Same as memory.dual_browser_test, but the test is run for 60 iterations
   and the browser is *not* restarted between page set repeats.
   """
   page_set = page_sets.DualBrowserStorySet
   options = {'pageset_repeat': 60}
 
   @classmethod
   def Name(cls):
     return 'memory.long_running_dual_browser_test'
 
   @classmethod
+  def ShouldTearDownStateAfterEachStoryRun(cls):
+    return False
+
+  @classmethod
   def ShouldTearDownStateAfterEachStorySetRun(cls):
     return False
 
   @classmethod
   def ValueCanBeAddedPredicate(cls, value, is_first_result):
     # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
     # is able to cope with the data load generated by TBMv2 metrics.
     return not _IGNORED_STATS_RE.search(value.name)
 
 
@@ skipping 81 matching lines @@
   of long running idle Gmail page """
   page_set = page_sets.LongRunningIdleGmailBackgroundPageSet
 
   @classmethod
   def Name(cls):
     return 'memory.long_running_idle_gmail_background_tbmv2'
 
   @classmethod
   def ShouldDisable(cls, possible_browser):  # http://crbug.com/616530
     return cls.IsSvelte(possible_browser)