Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2301373002: Make editing/inserting/typing-at-end-of-line.html not to use "editing.js" (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make editing/inserting/typing-at-end-of-line.html not to use "editing.js" This patch makes "editing/inserting/typing-at-end-of-line.html" not to use "editing.js" to avoid logging selection changes as a preparation of postpone visual position canonicalization, since this test verifies "layout" instead of editing functionality. BUG=625533 TEST=n/a; no behavior changes Committed: https://crrev.com/0c98c82a51910a35f9b407e429f924d1c36726a7 Cr-Commit-Position: refs/heads/master@{#416209}

Patch Set 1 : 2016-09-02T15:20:59 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/inserting/typing-at-end-of-line.html View 1 chunk +5 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
yosin_UTC9
PTAL After discussing layout guy in offline, we want to keep this test.
4 years, 3 months ago (2016-09-02 06:25:53 UTC) #4
Xiaocheng
On 2016/09/02 at 06:25:53, yosin wrote: > PTAL > > After discussing layout guy in ...
4 years, 3 months ago (2016-09-02 06:34:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301373002/1
4 years, 3 months ago (2016-09-02 06:37:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 07:49:08 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 07:50:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c98c82a51910a35f9b407e429f924d1c36726a7
Cr-Commit-Position: refs/heads/master@{#416209}

Powered by Google App Engine
This is Rietveld 408576698