Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2301353004:
Make AALinearizingConvexPathRenderer able to handle stroke and fill (Closed)
|
Created:
4 years, 3 months ago by robertphillips Modified:
4 years, 3 months ago CC:
reviews_skia.org Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionMake AALinearizingConvexPathRenderer able to handle stroke and fill
This is intended to catch stroke-and-fill convex paths with potentially small stroke widths (e.g., .1).
It does have the disconcerting side effect of changing bevel-joined stroke-and-filled degenerate-single-line-rects into plain rects (w/o triangular end-caps).
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004
Committed: https://skia.googlesource.com/skia/+/522bcd99fa65a8abd130880f59b500cf367d0845
Committed: https://skia.googlesource.com/skia/+/8c170971f182d47bc9af71fc88a607740d03dfd5
Patch Set 1 #Patch Set 2 : update #Patch Set 3 : Clean up #Patch Set 4 : More clean up #Patch Set 5 : Got a bit carried away there #Patch Set 6 : Fix compilation bug #
Total comments: 2
Patch Set 7 : Reverse sense of return value #Patch Set 8 : Fix bug #
Messages
Total messages: 42 (30 generated)
Description was changed from ========== Make AALinearizingConvexPathRenderer able to handle stroke and fill ========== to ========== Make AALinearizingConvexPathRenderer able to handle stroke and fill GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 ==========
Description was changed from ========== Make AALinearizingConvexPathRenderer able to handle stroke and fill GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 ========== to ========== Make AALinearizingConvexPathRenderer able to handle stroke and fill GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 ==========
robertphillips@google.com changed reviewers: + ethannicholas@google.com
Description was changed from ========== Make AALinearizingConvexPathRenderer able to handle stroke and fill GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 ========== to ========== Make AALinearizingConvexPathRenderer able to handle stroke and fill This is intended to catch stroke-and-fill convex paths with potentially small stroke widths (e.g., .1). It does have the disconcerting side effect of changing bevel joined stroke-and-filled rects into rects. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 ==========
ping - Ethan.
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-GN-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
robertphillips@google.com changed reviewers: + jvanverth@google.com
https://codereview.chromium.org/2301353004/diff/100001/src/gpu/batches/GrAACo... File src/gpu/batches/GrAAConvexTessellator.cpp (right): https://codereview.chromium.org/2301353004/diff/100001/src/gpu/batches/GrAACo... src/gpu/batches/GrAAConvexTessellator.cpp:41: return true; The return value of this function seems backward to me -- intersect() returns true if the function fails because the lines don't intersect?
Incidentally, what is going on with the bevel-joined stroke-and-filled degenerate-single-line-rects is that SkStroker has special-case handling of SkRects. The non-special case stroker also doesn't generate the pointy bits on the ends. https://codereview.chromium.org/2301353004/diff/100001/src/gpu/batches/GrAACo... File src/gpu/batches/GrAAConvexTessellator.cpp (right): https://codereview.chromium.org/2301353004/diff/100001/src/gpu/batches/GrAACo... src/gpu/batches/GrAAConvexTessellator.cpp:41: return true; On 2016/09/06 20:34:05, ethannicholas wrote: > The return value of this function seems backward to me -- intersect() returns > true if the function fails because the lines don't intersect? Haha - good point. Fixed.
Description was changed from ========== Make AALinearizingConvexPathRenderer able to handle stroke and fill This is intended to catch stroke-and-fill convex paths with potentially small stroke widths (e.g., .1). It does have the disconcerting side effect of changing bevel joined stroke-and-filled rects into rects. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 ========== to ========== Make AALinearizingConvexPathRenderer able to handle stroke and fill This is intended to catch stroke-and-fill convex paths with potentially small stroke widths (e.g., .1). It does have the disconcerting side effect of changing bevel-joined stroke-and-filled degenerate-single-line-rects into plain rects (w/o triangular end-caps). GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 ==========
On 2016/09/06 20:47:06, robertphillips wrote: > Incidentally, what is going on with the bevel-joined stroke-and-filled > degenerate-single-line-rects is that SkStroker has special-case handling of > SkRects. The non-special case stroker also doesn't generate the pointy bits on > the ends. > > https://codereview.chromium.org/2301353004/diff/100001/src/gpu/batches/GrAACo... > File src/gpu/batches/GrAAConvexTessellator.cpp (right): > > https://codereview.chromium.org/2301353004/diff/100001/src/gpu/batches/GrAACo... > src/gpu/batches/GrAAConvexTessellator.cpp:41: return true; > On 2016/09/06 20:34:05, ethannicholas wrote: > > The return value of this function seems backward to me -- intersect() returns > > true if the function fails because the lines don't intersect? > > Haha - good point. Fixed. lgtm
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Make AALinearizingConvexPathRenderer able to handle stroke and fill This is intended to catch stroke-and-fill convex paths with potentially small stroke widths (e.g., .1). It does have the disconcerting side effect of changing bevel-joined stroke-and-filled degenerate-single-line-rects into plain rects (w/o triangular end-caps). GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 ========== to ========== Make AALinearizingConvexPathRenderer able to handle stroke and fill This is intended to catch stroke-and-fill convex paths with potentially small stroke widths (e.g., .1). It does have the disconcerting side effect of changing bevel-joined stroke-and-filled degenerate-single-line-rects into plain rects (w/o triangular end-caps). GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 Committed: https://skia.googlesource.com/skia/+/522bcd99fa65a8abd130880f59b500cf367d0845 ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://skia.googlesource.com/skia/+/522bcd99fa65a8abd130880f59b500cf367d0845
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/2318183002/ by robertphillips@google.com. The reason for reverting is: Image quality issues on Android devices.
Message was sent while issue was closed.
Description was changed from ========== Make AALinearizingConvexPathRenderer able to handle stroke and fill This is intended to catch stroke-and-fill convex paths with potentially small stroke widths (e.g., .1). It does have the disconcerting side effect of changing bevel-joined stroke-and-filled degenerate-single-line-rects into plain rects (w/o triangular end-caps). GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 Committed: https://skia.googlesource.com/skia/+/522bcd99fa65a8abd130880f59b500cf367d0845 ========== to ========== Make AALinearizingConvexPathRenderer able to handle stroke and fill This is intended to catch stroke-and-fill convex paths with potentially small stroke widths (e.g., .1). It does have the disconcerting side effect of changing bevel-joined stroke-and-filled degenerate-single-line-rects into plain rects (w/o triangular end-caps). GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 Committed: https://skia.googlesource.com/skia/+/522bcd99fa65a8abd130880f59b500cf367d0845 ==========
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from ethannicholas@google.com Link to the patchset: https://codereview.chromium.org/2301353004/#ps140001 (title: "Fix bug")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Make AALinearizingConvexPathRenderer able to handle stroke and fill This is intended to catch stroke-and-fill convex paths with potentially small stroke widths (e.g., .1). It does have the disconcerting side effect of changing bevel-joined stroke-and-filled degenerate-single-line-rects into plain rects (w/o triangular end-caps). GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 Committed: https://skia.googlesource.com/skia/+/522bcd99fa65a8abd130880f59b500cf367d0845 ========== to ========== Make AALinearizingConvexPathRenderer able to handle stroke and fill This is intended to catch stroke-and-fill convex paths with potentially small stroke widths (e.g., .1). It does have the disconcerting side effect of changing bevel-joined stroke-and-filled degenerate-single-line-rects into plain rects (w/o triangular end-caps). GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 Committed: https://skia.googlesource.com/skia/+/522bcd99fa65a8abd130880f59b500cf367d0845 Committed: https://skia.googlesource.com/skia/+/8c170971f182d47bc9af71fc88a607740d03dfd5 ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://skia.googlesource.com/skia/+/8c170971f182d47bc9af71fc88a607740d03dfd5 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
