Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: services/ui/public/cpp/tests/test_window_tree_client_setup.cc

Issue 2301353003: Changes ownership of WindowTreeClient (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/public/cpp/tests/test_window_tree_client_setup.cc
diff --git a/services/ui/public/cpp/tests/test_window_tree_client_setup.cc b/services/ui/public/cpp/tests/test_window_tree_client_setup.cc
index 994b207151a869005978c4f482f8a78c703d482d..aa700e48da31e5043386ca59975109f5fe43312e 100644
--- a/services/ui/public/cpp/tests/test_window_tree_client_setup.cc
+++ b/services/ui/public/cpp/tests/test_window_tree_client_setup.cc
@@ -13,12 +13,7 @@ namespace ui {
TestWindowTreeClientSetup::TestWindowTreeClientSetup() {}
-TestWindowTreeClientSetup::~TestWindowTreeClientSetup() {
- std::unique_ptr<WindowTreeClient> window_tree_client =
- std::move(window_tree_client_);
- if (window_tree_client)
- window_tree_client->RemoveObserver(this);
-}
+TestWindowTreeClientSetup::~TestWindowTreeClientSetup() {}
void TestWindowTreeClientSetup::Init(
WindowTreeClientDelegate* window_tree_delegate) {
@@ -36,6 +31,11 @@ void TestWindowTreeClientSetup::InitForWindowManager(
.SetTreeAndClientId(window_tree_.get(), 1);
}
+std::unique_ptr<WindowTreeClient>
+TestWindowTreeClientSetup::OwnWindowTreeClient() {
+ return std::move(window_tree_client_);
sadrul 2016/09/02 17:04:15 Would it make sense to DCHECK(window_tree_client_)
sky 2016/09/06 17:15:42 Done.
+}
+
WindowTreeClient* TestWindowTreeClientSetup::window_tree_client() {
return window_tree_client_.get();
}
@@ -46,14 +46,6 @@ void TestWindowTreeClientSetup::CommonInit(
window_tree_.reset(new TestWindowTree);
window_tree_client_.reset(new WindowTreeClient(
window_tree_delegate, window_manager_delegate, nullptr));
- static_cast<WindowTreeClient*>(window_tree_client_.get())
- ->AddObserver(this);
-}
-
-void TestWindowTreeClientSetup::OnDidDestroyClient(
- ui::WindowTreeClient* client) {
- // See comment in header as to why we do this.
- window_tree_client_.release();
}
} // namespace ui

Powered by Google App Engine
This is Rietveld 408576698