Issue 230133002: drive::DownloadHandler should query DownloadHistory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 230133002: drive::DownloadHandler should query DownloadHistory. (Closed)

Created:
6 years, 8 months ago by asanka

Modified:
6 years, 7 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive::DownloadHandler should query DownloadHistory. The drive::DownloadHandler was using the assumption that all non-IN_PROGRESS downloads that are created were restored from history. This is not a safe assumption. Instead query the DownloadHistory to determine whether a new download was restored from history or not. Depends on https://codereview.chromium.org/230103002/ which adds a WasDownloadRestoredFromHistory method to DownloadHistory. BUG=7648 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271595