third_party/WebKit/Source/core/frame/Deprecation.cpp - Issue 2301323003: Add deprecation warning for script fetches with invalid types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2301323003: Add deprecation warning for script fetches with invalid types (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/ScriptLoader.cpp ('K') | « third_party/WebKit/Source/core/dom/ScriptLoader.cpp ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/Deprecation.cpp

diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp

index 71b341d3d91aa224705e35739dc506bcfb5875e0..4ae9a5af3b74c54e4fd9f994f5868eea60d81868 100644

--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp

+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp

@@ -381,6 +381,9 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature)

case UseCounter::NavigatorPointerEnabled:

return "Navigator.pointerEnabled is a non-standard API added for experiments only. It will be removed in near future.";

+ case UseCounter::ScriptInvalidTypeOrLanguage:

+ return String::format("Fetching scripts with an invalid type attribute is deprecated and will be removed in %s. See https://html.spec.whatwg.org/#javascript-mime-type for a list of valid types.", milestoneString(56));

// Features that aren't deprecated don't have a deprecation message.

default:

return String();