Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2301273002: GN: Build and link with LLD when using our Clang toolchain. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
herb_g, borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: Build and link with LLD when using our Clang toolchain. I am hoping this makes it easier to get *SAN bots going. Today we're generating a libcompiler_rt.a that's using a relocation type that the ld on the bots doesn't know about. This lld is will know about anything our Clang generates. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301273002 Committed: https://skia.googlesource.com/skia/+/795423198ba883393a56196c6ea4481efabba311

Patch Set 1 #

Patch Set 2 : v3 #

Messages

Total messages: 12 (6 generated)
mtklein_C
Please review the parts you are familiar with.
4 years, 3 months ago (2016-09-01 22:05:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301273002/20001
4 years, 3 months ago (2016-09-01 22:06:00 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-01 22:06:01 UTC) #8
borenet
LGTM. Trybots for this should work.
4 years, 3 months ago (2016-09-01 22:07:42 UTC) #9
mtklein_C
On 2016/09/01 at 22:07:42, borenet wrote: > LGTM. Trybots for this should work. Looks like ...
4 years, 3 months ago (2016-09-01 22:47:09 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 22:51:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/795423198ba883393a56196c6ea4481efabba311

Powered by Google App Engine
This is Rietveld 408576698