Add WebAPK installation metrics.

chrome/browser/android/banners/app_banner_infobar_delegate_android.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_
 #define CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_
 
 #include "base/android/scoped_java_ref.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/banners/app_banner_manager.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 #include "ui/gfx/image/image.h"
 #include "url/gurl.h"
 
 namespace content {
 class WebContents;
 }
 
 namespace infobars {
 class InfoBarManager;
 }
 
 class AppBannerInfoBar;
 struct ShortcutInfo;
 
 namespace banners {
 
+// The states of WebAPK installation process. These states are tracked to
+// record dismiss events for WebAPK installation.
+enum InstallState {

[dominickn, 2016/09/19 01:38:39]

Nit: call this WebApkInstallState, and change the comment to:

"The state of a WebAPK installation, where the infobar is displayed during the
entire installation process. This state is used to correctly record UMA
metrics".


Second nit: consider making this enum a private member of
AppBannerInfoBarDelegate, since it's an implementation detail. The method in the
anonymous namespace of the cc file can also move to the private area of the
class.

[Xi Han, 2016/09/20 18:25:18]

Done.

+  WAIT_FOR_START,

[dominickn, 2016/09/19 01:38:39]

Nit: "INSTALL_NOT_STARTED"?

[Xi Han, 2016/09/20 18:25:18]

Done.

+  INSTALLING,
+  INSTALLED,
+};
+
 // Manages installation of an app being promoted by a page.
 class AppBannerInfoBarDelegateAndroid : public ConfirmInfoBarDelegate {
  public:
   // Creates an infobar and delegate for promoting the installation of a web
   // app, and adds the infobar to the InfoBarManager for |web_contents|.
   static bool Create(
       content::WebContents* web_contents,
       base::WeakPtr<AppBannerManager> weak_manager,
       const base::string16& app_title,
       std::unique_ptr<ShortcutInfo> info,
@@ skipping 85 matching lines @@
 
   std::unique_ptr<SkBitmap> icon_;
 
   std::string native_app_package_;
   std::string referrer_;
   int event_request_id_;
   bool has_user_interaction_;
 
   std::string webapk_package_name_;
   bool is_webapk_;
+  // Indicates the current state of a WebAPK installation.

[dominickn, 2016/09/19 01:38:39]

Nit: add a newline above the comment.

[Xi Han, 2016/09/20 18:25:18]

Done.

+  InstallState install_state_;
 
   base::WeakPtrFactory<AppBannerInfoBarDelegateAndroid> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AppBannerInfoBarDelegateAndroid);
 };
 
 // Register native methods.
 bool RegisterAppBannerInfoBarDelegateAndroid(JNIEnv* env);
 
 }  // namespace banners
 
 #endif  // CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_