Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2301233002: Update Skia GN build to use the new .gni file. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
mtklein_C
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Skia GN build to use the new .gni file. This file is provided by the Skia repo so the GN Chrome build doesn't have to make assumptions about the location and layout of Skia's GYP files. Committed: https://crrev.com/cf9457edb7c734f509dd12149acd78410c518570 Cr-Commit-Position: refs/heads/master@{#416297}

Patch Set 1 #

Patch Set 2 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -103 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M skia/BUILD.gn View 1 15 chunks +24 lines, -103 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
brettw
style
4 years, 3 months ago (2016-09-01 20:40:28 UTC) #1
brettw
4 years, 3 months ago (2016-09-01 20:40:38 UTC) #3
mtklein_C
lgtm
4 years, 3 months ago (2016-09-01 20:56:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301233002/20001
4 years, 3 months ago (2016-09-02 16:52:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 17:54:42 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 17:56:19 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf9457edb7c734f509dd12149acd78410c518570
Cr-Commit-Position: refs/heads/master@{#416297}

Powered by Google App Engine
This is Rietveld 408576698