Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h

Issue 2301213003: Add tests for trace wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix StringView problem Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
index 3b73e129ad53aef1408d9f698b56a0cb69324e48..10f3f62f46f8ad2f7244aeb6e90b83a4a1cea7ac 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
@@ -53,6 +53,12 @@ public:
return !m_object || heapObjectHeader()->isWrapperHeaderMarked();
}
+ /**
+ * Returns raw object pointer. Beware it doesn't necessarily point to the
+ * beginning of the object.
+ */
+ const void* object() { return m_object; }
haraken 2016/09/02 10:53:14 I'd rename this to rawObjectPointer or something.
Marcel Hlopko 2016/09/02 12:12:40 Done.
+
private:
inline bool shouldBeInvalidated()
{
@@ -144,6 +150,10 @@ public:
*/
void markWrappersInAllWorlds(const ScriptWrappable*) const override;
void markWrappersInAllWorlds(const void*) const override {}
+
+ WTF::Deque<WrapperMarkingData>* getMarkingDeque() { return &m_markingDeque; }
+ WTF::Deque<WrapperMarkingData>* getVerifierDeque() { return &m_verifierDeque; }
+ WTF::Vector<HeapObjectHeader*>* getHeadersToUnmark() { return &m_headersToUnmark; }
private:
/**
* Is wrapper tracing currently in progress? True if TracePrologue has been

Powered by Google App Engine
This is Rietveld 408576698