Add tests for trace wrappers

third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 374 matching lines @@
             // The conservative GC might have left floating garbage. Schedule
             // precise GC to ensure that we collect all available garbage.
             if (ThreadState::current())
                 ThreadState::current()->schedulePreciseGC();
         }
     }
 
     TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "UpdateCounters", TRACE_EVENT_SCOPE_THREAD, "data", InspectorUpdateCountersEvent::data());
 }
 
-void V8GCController::collectGarbage(v8::Isolate* isolate)
+void V8GCController::collectGarbage(v8::Isolate* isolate, bool onlyMinorGc)

[haraken, 2016/09/02 10:53:14]

onlyMinorGC

[Marcel Hlopko, 2016/09/02 12:12:40]

Done.

 {
     v8::HandleScope handleScope(isolate);
     RefPtr<ScriptState> scriptState = ScriptState::create(v8::Context::New(isolate), DOMWrapperWorld::create(isolate));
     ScriptState::Scope scope(scriptState.get());
-    V8ScriptRunner::compileAndRunInternalScript(v8String(isolate, "if (gc) gc();"), isolate);
+    String flag = onlyMinorGc ? "true" : "false";
+    V8ScriptRunner::compileAndRunInternalScript(
+        v8String(isolate, (String) ("if (gc) gc(" + flag + ")")), isolate);

[haraken, 2016/09/02 10:53:14]

Use StringBuilder instead.

StringBuilder builder = "if (gc) gc(";
builder.append(onlyMinorGC ? "true" : "false");
builder.append(")");

[Marcel Hlopko, 2016/09/02 12:12:40]

Done.

     scriptState->disposePerContextData();
 }
 
 void V8GCController::collectAllGarbageForTesting(v8::Isolate* isolate)
 {
     for (unsigned i = 0; i < 5; i++)
         isolate->RequestGarbageCollectionForTesting(v8::Isolate::kFullGarbageCollection);
 }
 
 class DOMWrapperTracer : public v8::PersistentHandleVisitor {
@@ skipping 80 matching lines @@
     DEFINE_THREAD_SAFE_STATIC_LOCAL(CustomCountHistogram, scanPendingActivityHistogram, new CustomCountHistogram("Blink.ScanPendingActivityDuration", 1, 1000, 50));
     double startTime = WTF::currentTimeMS();
     v8::HandleScope scope(isolate);
     PendingActivityVisitor visitor(isolate, executionContext);
     toIsolate(executionContext)->VisitHandlesWithClassIds(&visitor);
     scanPendingActivityHistogram.count(static_cast<int>(WTF::currentTimeMS() - startTime));
     return visitor.pendingActivityFound();
 }
 
 } // namespace blink