Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: BUILD.gn

Issue 2301213002: Don't allow official component builds (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index acc203c143b692ca031da0b66153847e653a366a..8996d99d0827c7035fdea81258ee466c62e38e0a 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -30,6 +30,12 @@ declare_args() {
root_extra_deps = []
}
+if (is_official_build) {
+ # An official (maximally optimized!) component (optimized for build times)
+ # build doesn't make sense and usually doesn't work.
+ assert(!is_component_build)
+}
+
# This file defines the following five main targets:
#
# "both_gn_and_gyp" should list every root target (target that nothing else
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698