Don't allow official component builds

Don't allow official component builds

Official component builds generally don't work, and they are logically
contradictory, so it is better to prevent them with an assert in order
to save developers from this mistake.

Committed: https://crrev.com/c8d6d6517d2b5745814a3bd6c5fdf29e3ffd1671
Cr-Commit-Position: refs/heads/master@{#416321}

[brucedawson, 2016-09-02 01:25:06]

brucedawson@chromium.org changed reviewers:
+ dpranke@chromium.org

[brucedawson, 2016-09-02 01:25:07]

An external developer hit this and reported it on chromium-dev. Any reason not
to prohibit this combination of build flags?

[Dirk Pranke, 2016-09-02 04:11:50]

I think this is probably fine, given that official builds are usually using WPO
and component builds would hurt that (and also not reflect what is shipped).

So, lgtm.

[brucedawson, 2016-09-02 18:05:15]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-09-02 18:06:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 19:43:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-02 19:45:40]

Description was changed from

==========
Don't allow official component builds

Official component builds generally don't work, and they are logically
contradictory, so it is better to prevent them with an assert in order
to save developers from this mistake.
==========

to

==========
Don't allow official component builds

Official component builds generally don't work, and they are logically
contradictory, so it is better to prevent them with an assert in order
to save developers from this mistake.

Committed: https://crrev.com/c8d6d6517d2b5745814a3bd6c5fdf29e3ffd1671
Cr-Commit-Position: refs/heads/master@{#416321}
==========

[commit-bot: I haz the power, 2016-09-02 19:45:41]

Patchset 1 (id:??) landed as
https://crrev.com/c8d6d6517d2b5745814a3bd6c5fdf29e3ffd1671
Cr-Commit-Position: refs/heads/master@{#416321}