Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2301203002: Disallow non-namespaced use of base::Version. (Closed)

Created:
4 years, 3 months ago by pwnall
Modified:
4 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow non-namespaced use of base::Version. This is a reland of https://crrev.com/706bd25d40c82c7cb8dadb99ce24b8ebfd4a09ab which is a reland of https://crrev.com/bc8e5f797c9fac1708ab7b27da4d96ec274c6ca0 which is a reland of https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910 BUG=639416 Committed: https://crrev.com/8c3feb2c648dd37482f1e74c2436060dc46c0078 Cr-Commit-Position: refs/heads/master@{#416053}

Patch Set 1 #

Patch Set 2 : Corrected another instance of non-namespaced base::Version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M base/version.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/obsolete_system/obsolete_system_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
pwnall
PT(Y)AL? FWIW, I chatted with the sheriff and couldn't come up with a better way ...
4 years, 3 months ago (2016-09-01 20:40:59 UTC) #4
Nico
lgtm
4 years, 3 months ago (2016-09-01 20:42:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301203002/20001
4 years, 3 months ago (2016-09-01 21:04:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 21:11:07 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 21:14:19 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c3feb2c648dd37482f1e74c2436060dc46c0078
Cr-Commit-Position: refs/heads/master@{#416053}

Powered by Google App Engine
This is Rietveld 408576698