Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2301193002: Remove gyp-win-tool. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove gyp-win-tool. Now that NaCl has rolled and no longer references this script in the build directory, we can stop copying it to the build directory. BUG=642014 Committed: https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165 Committed: https://crrev.com/bfa71bfa84058e372b33f7a24c09a7d72a7cdbc0 Cr-Original-Commit-Position: refs/heads/master@{#416052} Cr-Commit-Position: refs/heads/master@{#416703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -45 lines) Patch
M build/toolchain/win/BUILD.gn View 3 chunks +0 lines, -6 lines 0 comments Download
M build/toolchain/win/setup_toolchain.py View 2 chunks +9 lines, -39 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
brettw
4 years, 3 months ago (2016-09-01 19:39:24 UTC) #2
scottmg
lgtm One last reference here https://cs.chromium.org/chromium/build/scripts/slave/build_directory.py?rcl=0&l=97 if you don't already have a CL for that.
4 years, 3 months ago (2016-09-01 19:41:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301193002/1
4 years, 3 months ago (2016-09-01 21:00:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 21:10:20 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165 Cr-Commit-Position: refs/heads/master@{#416052}
4 years, 3 months ago (2016-09-01 21:11:59 UTC) #12
fgorski
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2296053004/ by fgorski@chromium.org. ...
4 years, 3 months ago (2016-09-01 21:47:02 UTC) #13
scottmg
Doh! I thought NaCl had rolled. :(
4 years, 3 months ago (2016-09-01 21:51:40 UTC) #14
scottmg
Doh! I thought NaCl had rolled. :(
4 years, 3 months ago (2016-09-01 21:51:42 UTC) #15
findit-for-me
FYI: Findit try jobs (rerunning failed compile or tests) identified this CL at revision 416052 ...
4 years, 3 months ago (2016-09-01 22:26:25 UTC) #16
brettw
Reopening and relanding, nacl has finally rolled.
4 years, 3 months ago (2016-09-06 18:11:44 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301193002/1
4 years, 3 months ago (2016-09-06 18:12:31 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 20:29:58 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 20:31:36 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfa71bfa84058e372b33f7a24c09a7d72a7cdbc0
Cr-Commit-Position: refs/heads/master@{#416703}

Powered by Google App Engine
This is Rietveld 408576698