|
|
Chromium Code Reviews
DescriptionRemove gyp-win-tool.
Now that NaCl has rolled and no longer references this script in the build directory, we can stop copying it to the build directory.
BUG=642014
Committed: https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165
Committed: https://crrev.com/bfa71bfa84058e372b33f7a24c09a7d72a7cdbc0
Cr-Original-Commit-Position: refs/heads/master@{#416052}
Cr-Commit-Position: refs/heads/master@{#416703}
Patch Set 1 #
Messages
Total messages: 24 (11 generated)
brettw@chromium.org changed reviewers: + scottmg@chromium.org
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm One last reference here https://cs.chromium.org/chromium/build/scripts/slave/build_directory.py?rcl=0... if you don't already have a CL for that.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove gyp-win-tool. Now that NaCl has rolled and no longer references this script in the build directory, we can stop copying it to the build directory. BUG=642014 ========== to ========== Remove gyp-win-tool. Now that NaCl has rolled and no longer references this script in the build directory, we can stop copying it to the build directory. BUG=642014 Committed: https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165 Cr-Commit-Position: refs/heads/master@{#416052} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165 Cr-Commit-Position: refs/heads/master@{#416052}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2296053004/ by fgorski@chromium.org. The reason for reverting is: Build broken with change: https://build.chromium.org/p/chromium/builders/Win/builds/46673.
Message was sent while issue was closed.
Doh! I thought NaCl had rolled. :(
Message was sent while issue was closed.
Doh! I thought NaCl had rolled. :(
Message was sent while issue was closed.
FYI: Findit try jobs (rerunning failed compile or tests) identified this CL at revision 416052 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
Message was sent while issue was closed.
Description was changed from ========== Remove gyp-win-tool. Now that NaCl has rolled and no longer references this script in the build directory, we can stop copying it to the build directory. BUG=642014 Committed: https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165 Cr-Commit-Position: refs/heads/master@{#416052} ========== to ========== Remove gyp-win-tool. Now that NaCl has rolled and no longer references this script in the build directory, we can stop copying it to the build directory. BUG=642014 Committed: https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165 Cr-Commit-Position: refs/heads/master@{#416052} ==========
Reopening and relanding, nacl has finally rolled.
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove gyp-win-tool. Now that NaCl has rolled and no longer references this script in the build directory, we can stop copying it to the build directory. BUG=642014 Committed: https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165 Cr-Commit-Position: refs/heads/master@{#416052} ========== to ========== Remove gyp-win-tool. Now that NaCl has rolled and no longer references this script in the build directory, we can stop copying it to the build directory. BUG=642014 Committed: https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165 Cr-Commit-Position: refs/heads/master@{#416052} ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove gyp-win-tool. Now that NaCl has rolled and no longer references this script in the build directory, we can stop copying it to the build directory. BUG=642014 Committed: https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165 Cr-Commit-Position: refs/heads/master@{#416052} ========== to ========== Remove gyp-win-tool. Now that NaCl has rolled and no longer references this script in the build directory, we can stop copying it to the build directory. BUG=642014 Committed: https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165 Committed: https://crrev.com/bfa71bfa84058e372b33f7a24c09a7d72a7cdbc0 Cr-Original-Commit-Position: refs/heads/master@{#416052} Cr-Commit-Position: refs/heads/master@{#416703} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/bfa71bfa84058e372b33f7a24c09a7d72a7cdbc0 Cr-Commit-Position: refs/heads/master@{#416703} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
