Chromium Code Reviews
DescriptionRevert of Disallow non-namespaced use of base::Version. (patchset #1 id:1 of https://codereview.chromium.org/2298923003/ )
Reason for revert:
Build broken again:
https://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Linux%20x64&number=13369
Original issue's description:
> Disallow non-namespaced use of base::Version.
>
> This is a reland of
> https://crrev.com/bc8e5f797c9fac1708ab7b27da4d96ec274c6ca0
> which is a reland of
> https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910
>
> BUG=639416
>
> Committed: https://crrev.com/706bd25d40c82c7cb8dadb99ce24b8ebfd4a09ab
> Cr-Commit-Position: refs/heads/master@{#415991}
TBR=thakis@chromium.org,pwnall@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=639416
Committed: https://crrev.com/bd28ba5979255a1a328acb3916ca7f985bf0cd0e
Cr-Commit-Position: refs/heads/master@{#416017}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||