Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2301183002: Revert of Disallow non-namespaced use of base::Version. (Closed)

Created:
4 years, 3 months ago by fgorski
Modified:
4 years, 3 months ago
Reviewers:
Nico, pwnall
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disallow non-namespaced use of base::Version. (patchset #1 id:1 of https://codereview.chromium.org/2298923003/ ) Reason for revert: Build broken again: https://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Linux%20x64&number=13369 Original issue's description: > Disallow non-namespaced use of base::Version. > > This is a reland of > https://crrev.com/bc8e5f797c9fac1708ab7b27da4d96ec274c6ca0 > which is a reland of > https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910 > > BUG=639416 > > Committed: https://crrev.com/706bd25d40c82c7cb8dadb99ce24b8ebfd4a09ab > Cr-Commit-Position: refs/heads/master@{#415991} TBR=thakis@chromium.org,pwnall@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=639416 Committed: https://crrev.com/bd28ba5979255a1a328acb3916ca7f985bf0cd0e Cr-Commit-Position: refs/heads/master@{#416017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M base/version.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/obsolete_system/obsolete_system_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
fgorski
Created Revert of Disallow non-namespaced use of base::Version.
4 years, 3 months ago (2016-09-01 19:37:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301183002/1
4 years, 3 months ago (2016-09-01 19:37:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 19:38:35 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 19:39:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd28ba5979255a1a328acb3916ca7f985bf0cd0e
Cr-Commit-Position: refs/heads/master@{#416017}

Powered by Google App Engine
This is Rietveld 408576698