Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2301143002: The psuedo-objects are not instances: give them cids above kInstanceCid. (Closed)

Created:
4 years, 3 months ago by rmacnak
Modified:
4 years, 3 months ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

The psuedo-objects are not instances: give them cids above kInstanceCid. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/7c74db24ca2b51f34bd3e6103bf20546eff05f80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M runtime/vm/raw_object.h View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 3 months ago (2016-09-01 18:04:29 UTC) #2
siva
lgtm
4 years, 3 months ago (2016-09-01 22:35:56 UTC) #3
rmacnak
4 years, 3 months ago (2016-09-02 16:34:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7c74db24ca2b51f34bd3e6103bf20546eff05f80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698