Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2301113003: Remove all extensions/renderer and c/r/extensions linked_ptr usage. (Closed)

Created:
4 years, 3 months ago by lazyboy
Modified:
4 years, 3 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all extensions/renderer and c/r/extensions linked_ptr usage. All of them seem trivial, make them use std::unique_ptr. BUG=556939 Test=None, internal only change. Committed: https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166 Cr-Commit-Position: refs/heads/master@{#416195}

Patch Set 1 #

Patch Set 2 : sync @tott #

Total comments: 4

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -64 lines) Patch
M chrome/renderer/extensions/cast_streaming_native_handler.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.cc View 1 2 6 chunks +13 lines, -14 lines 0 comments Download
M components/guest_view/renderer/guest_view_container.h View 4 chunks +4 lines, -5 lines 0 comments Download
M components/guest_view/renderer/guest_view_container.cc View 2 chunks +13 lines, -8 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M extensions/renderer/object_backed_native_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/object_backed_native_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/request_sender.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/renderer/request_sender.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M extensions/renderer/resource_bundle_source_map.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/user_script_set_manager.h View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/renderer/user_script_set_manager.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
lazyboy
Hi, one quick one for ya.
4 years, 3 months ago (2016-09-02 00:22:42 UTC) #2
Devlin
lgtm https://codereview.chromium.org/2301113003/diff/20001/chrome/renderer/extensions/cast_streaming_native_handler.h File chrome/renderer/extensions/cast_streaming_native_handler.h (right): https://codereview.chromium.org/2301113003/diff/20001/chrome/renderer/extensions/cast_streaming_native_handler.h#newcode143 chrome/renderer/extensions/cast_streaming_native_handler.h:143: std::map<int, std::unique_ptr<v8::Global<v8::Function>>>; hmm... I think v8::Globals have a ...
4 years, 3 months ago (2016-09-02 00:54:22 UTC) #5
lazyboy
https://codereview.chromium.org/2301113003/diff/20001/chrome/renderer/extensions/cast_streaming_native_handler.h File chrome/renderer/extensions/cast_streaming_native_handler.h (right): https://codereview.chromium.org/2301113003/diff/20001/chrome/renderer/extensions/cast_streaming_native_handler.h#newcode143 chrome/renderer/extensions/cast_streaming_native_handler.h:143: std::map<int, std::unique_ptr<v8::Global<v8::Function>>>; On 2016/09/02 00:54:22, Devlin wrote: > hmm... ...
4 years, 3 months ago (2016-09-02 02:48:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301113003/40001
4 years, 3 months ago (2016-09-02 05:27:29 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 05:32:52 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 05:35:32 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166
Cr-Commit-Position: refs/heads/master@{#416195}

Powered by Google App Engine
This is Rietveld 408576698