Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: pkg/polymer/lib/src/transform/code_extractor.dart

Issue 23011045: Declare the sequence of phases for the full polymer transform and add tests for (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/polymer/lib/src/transform.dart ('k') | pkg/polymer/lib/src/transform/script_compactor.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** Transfomer that extracts inlined script code into separate assets. */ 5 /** Transfomer that extracts inlined script code into separate assets. */
6 library polymer.src.transformers; 6 library polymer.src.transformers;
7 7
8 import 'dart:async'; 8 import 'dart:async';
9 9
10 import 'package:barback/barback.dart'; 10 import 'package:barback/barback.dart';
11 import 'package:path/path.dart' as path; 11 import 'package:path/path.dart' as path;
12 12
13 import 'common.dart'; 13 import 'common.dart';
14 14
15 /** 15 /**
16 * Transformer that extracts Dart code inlined in HTML script tags and outputs a 16 * Transformer that extracts Dart code inlined in HTML script tags and outputs a
17 * separate file for each. 17 * separate file for each.
18 */ 18 */
19 class InlineCodeExtractor extends Transformer { 19 class InlineCodeExtractor extends Transformer {
20 Future<bool> isPrimary(Asset input) => 20 Future<bool> isPrimary(Asset input) =>
21 new Future.value(input.id.extension == ".html"); 21 new Future.value(input.id.extension == ".html");
22 22
23 Future apply(Transform transform) { 23 Future apply(Transform transform) {
24 var inputId = transform.primaryId; 24 var inputId = transform.primaryId;
25 return getPrimaryContent(transform).then((content) { 25 return getPrimaryContent(transform).then((content) {
26 var document = parseHtml(content, inputId.path, transform.logger); 26 var document = parseHtml(content, inputId.path, transform.logger);
27 int count = 0; 27 int count = 0;
28 bool htmlChanged = false;
28 for (var tag in document.queryAll('script')) { 29 for (var tag in document.queryAll('script')) {
29 if (tag.attributes['type'] == 'application/dart' && 30 // Only process tags that have inline Dart code
30 !tag.attributes.containsKey('src')) { 31 if (tag.attributes['type'] != 'application/dart' ||
31 // TODO(sigmund): should we automatically include a library directive 32 tag.attributes.containsKey('src')) {
32 // if it doesn't have one? 33 continue;
33 var filename = path.url.basename(inputId.path);
34 tag.attributes['src'] = '$filename.$count.dart';
35 var textContent = tag.nodes.first;
36 var id = inputId.addExtension('.$count.dart');
37 transform.addOutput(new Asset.fromString(id, textContent.value));
38 textContent.remove();
39 count++;
40 } 34 }
35 htmlChanged = true;
36
37 // Remove empty tags
38 if (tag.nodes.length == 0) {
39 tag.remove();
40 continue;
41 }
42
43 // TODO(sigmund): should we automatically include a library directive
44 // if it doesn't have one?
45 var filename = path.url.basename(inputId.path);
46 // TODO(sigmund): ensure this filename is unique (dartbug.com/12618).
47 tag.attributes['src'] = '$filename.$count.dart';
48 var textContent = tag.nodes.first;
49 var id = inputId.addExtension('.$count.dart');
50 transform.addOutput(new Asset.fromString(id, textContent.value));
51 textContent.remove();
52 count++;
41 } 53 }
42 transform.addOutput(new Asset.fromString(inputId, 54 transform.addOutput(new Asset.fromString(inputId,
43 count == 0 ? content : document.outerHtml)); 55 htmlChanged ? document.outerHtml : content));
44 }); 56 });
45 } 57 }
46 } 58 }
OLDNEW
« no previous file with comments | « pkg/polymer/lib/src/transform.dart ('k') | pkg/polymer/lib/src/transform/script_compactor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698