Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2301103004: Remove DCHEcK(!m_clipped) (Closed)

Created:
4 years, 3 months ago by chrishtr
Modified:
4 years, 3 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DCHEcK(!m_clipped) A clip could have been added by addClipRectRelativeToPaintOffset, so the DCHECK is not valid. BUG=642273 Committed: https://crrev.com/957cc38dbddea1dc412522793629439d1c5b46ac Cr-Commit-Position: refs/heads/master@{#416705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
chrishtr
4 years, 3 months ago (2016-09-02 20:39:26 UTC) #3
Xianzhu
On 2016/09/02 20:39:26, chrishtr wrote: lgtm. In description: > by addClipRectRelativeToPaintOffset or addClipRectRelativeToPaintOffset Is there ...
4 years, 3 months ago (2016-09-06 16:20:51 UTC) #8
chrishtr
On 2016/09/06 at 16:20:51, wangxianzhu wrote: > On 2016/09/02 20:39:26, chrishtr wrote: > > lgtm. ...
4 years, 3 months ago (2016-09-06 16:34:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301103004/1
4 years, 3 months ago (2016-09-06 16:35:12 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 20:31:57 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 20:33:58 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/957cc38dbddea1dc412522793629439d1c5b46ac
Cr-Commit-Position: refs/heads/master@{#416705}

Powered by Google App Engine
This is Rietveld 408576698