Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: ipc/ipc_channel_common.cc

Issue 2301103003: Use ChannelMojo for NaCl PPAPI channels. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_channel.h ('k') | ipc/ipc_channel_handle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_common.cc
diff --git a/ipc/ipc_channel_common.cc b/ipc/ipc_channel_common.cc
index adb0dd29f5910dc1eafc424b4bfee6d48c646853..10b88b6de7eee7f3546689a3e956dc07de419399 100644
--- a/ipc/ipc_channel_common.cc
+++ b/ipc/ipc_channel_common.cc
@@ -55,22 +55,9 @@ void Channel::GenerateMojoChannelHandlePair(
IPC::ChannelHandle* handle0,
IPC::ChannelHandle* handle1) {
DCHECK_NE(handle0, handle1);
- // |name| is only used for logging and to aid developers in debugging. It
- // doesn't _need_ to be unique, but this string is probably more useful than a
- // generic "ChannelMojo".
-#if !defined(OS_NACL_SFI)
- std::string name = "ChannelMojo-" + GenerateUniqueRandomChannelID();
-#else
- std::string name = "ChannelMojo";
-#endif
- if (!name_postfix.empty()) {
- name += "-" + name_postfix;
- }
mojo::MessagePipe message_pipe;
- *handle0 = ChannelHandle(name);
- handle0->mojo_handle = message_pipe.handle0.release();
- *handle1 = ChannelHandle(name);
- handle1->mojo_handle = message_pipe.handle1.release();
+ *handle0 = ChannelHandle(message_pipe.handle0.release());
+ *handle1 = ChannelHandle(message_pipe.handle1.release());
}
Channel::~Channel() {
« no previous file with comments | « ipc/ipc_channel.h ('k') | ipc/ipc_channel_handle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698