Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: components/nacl/loader/nonsfi/nonsfi_listener.cc

Issue 2301103003: Use ChannelMojo for NaCl PPAPI channels. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/loader/nonsfi/nonsfi_listener.cc
diff --git a/components/nacl/loader/nonsfi/nonsfi_listener.cc b/components/nacl/loader/nonsfi/nonsfi_listener.cc
index c89594b3df93d7c5db3561cd040442d45ccc87c8..a0ba4d05bcad8c854247799f5c3190b6c9f0c46d 100644
--- a/components/nacl/loader/nonsfi/nonsfi_listener.cc
+++ b/components/nacl/loader/nonsfi/nonsfi_listener.cc
@@ -109,10 +109,10 @@ void NonSfiListener::OnStart(const nacl::NaClStartParams& params) {
// plugin's main thread. We just pass the FDs to plugin side.
// The FDs are created in the browser process. Following check can fail
// if the preparation for sending NaClProcessMsg_Start were incomplete.
- CHECK_NE(params.ppapi_browser_channel_handle.socket.fd, -1);
- CHECK_NE(params.ppapi_renderer_channel_handle.socket.fd, -1);
- CHECK_NE(params.trusted_service_channel_handle.socket.fd, -1);
- CHECK_NE(params.manifest_service_channel_handle.socket.fd, -1);
+ CHECK(params.ppapi_browser_channel_handle.mojo_handle.is_valid());
+ CHECK(params.ppapi_renderer_channel_handle.mojo_handle.is_valid());
+ CHECK(params.trusted_service_channel_handle.mojo_handle.is_valid());
+ CHECK(params.manifest_service_channel_handle.mojo_handle.is_valid());
ppapi::SetIPCChannelHandles(
params.ppapi_browser_channel_handle,

Powered by Google App Engine
This is Rietveld 408576698