include/core/SkCanvas.h - Issue 23011012: Implement correct clipping for image filters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkCanvas.h

Issue 23011012: Implement correct clipping for image filters. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Cleanup Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkCanvas.h

diff --git a/include/core/SkCanvas.h b/include/core/SkCanvas.h

index c98ad996f0786caccf75d3f74dca3dbc68edda10..372fe36ada9a15d15d98e211d6179f87fa32dc9a 100644

--- a/include/core/SkCanvas.h

+++ b/include/core/SkCanvas.h

@@ -1028,7 +1028,7 @@ protected:

// Clip rectangle bounds. Called internally by saveLayer.

// returns false if the entire rectangle is entirely clipped out

reed1 2014/02/04 15:30:08 Lets add dox for how the optional imageFilter para

Stephen White 2014/02/04 16:01:41 Done.

bool clipRectBounds(const SkRect* bounds, SaveFlags flags,

- SkIRect* intersection);

+ SkIRect* intersection, const SkImageFilter* imageFilter = NULL);

reed1 2014/02/04 15:30:08 nit: SkCanvas.h is predominantly 80-col

Stephen White 2014/02/04 16:01:41 Fixed.

// Called by child classes that override clipPath and clipRRect to only

// track fast conservative clip bounds, rather than exact clips.