Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2301093002: predictors: Remove unused histograms for speculative_prefetch_predictor. (Closed)

Created:
4 years, 3 months ago by Benoit L
Modified:
4 years, 3 months ago
Reviewers:
pasko, Ilya Sherman
CC:
chromium-reviews, shishir+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Remove unused histograms for speculative_prefetch_predictor. These histograms will no longer be accurate and prevent code refactoring and improvements. Also fixes the presubmit check: cannot assume that the first element of sys.path is '.', and tools/python doesn't contain __init__.py. BUG=631966 Committed: https://crrev.com/997952d9496f57bdc4434d515a50770dd5735715 Cr-Commit-Position: refs/heads/master@{#416232}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -517 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 1 2 14 chunks +20 lines, -474 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
M tools/metrics/common/presubmit_util.py View 2 chunks +5 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 38 chunks +114 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Benoit L
4 years, 3 months ago (2016-09-01 18:32:31 UTC) #6
Benoit L
On 2016/09/01 18:32:31, Benoit L wrote: isherman: please review histograms.xlm and presubmit_util.py, thanks! pasko: everything ...
4 years, 3 months ago (2016-09-01 18:33:33 UTC) #7
Ilya Sherman
//tools/metrics LGTM, thanks =)
4 years, 3 months ago (2016-09-01 19:13:42 UTC) #8
pasko
LGTM, thank you
4 years, 3 months ago (2016-09-02 10:55:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301093002/40001
4 years, 3 months ago (2016-09-02 10:59:16 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 11:03:37 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 11:05:52 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/997952d9496f57bdc4434d515a50770dd5735715
Cr-Commit-Position: refs/heads/master@{#416232}

Powered by Google App Engine
This is Rietveld 408576698