Optimization: avoid making 4 JNI calls to get touch device attributes.

Optimization: avoid making 4 JNI calls to get touch device attributes.

Each call (Get{Available|Primary}{Pointer|Hover}Type) does a separate
iteration over the input device list, as well as incurring JNI call
overhead. By fetching the Pointer and Hover types in one call, and
then reusing the values, we can avoid unnecessary work on the WebView
startup path.

BUG=600060
Committed: https://crrev.com/4cef7d0449592119bc8bdee2b5a98c89543f4c03
Cr-Commit-Position: refs/heads/master@{#416644}

[Tobias Sargeant, 2016-09-01 15:27:13]

The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run

[Tobias Sargeant, 2016-09-01 15:27:25]

tobiasjs@chromium.org changed reviewers:
+ sadrul@chromium.org

[commit-bot: I haz the power, 2016-09-01 15:27:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 17:16:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 17:16:36]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-09-01 23:22:36]

Looks reasonable. But I think we should remove the existing API too, since they
are not used anymore.

Can you also add an owner from ui/android for the java code?

https://codereview.chromium.org/2301073002/diff/1/ui/base/touch/touch_device.h
File ui/base/touch/touch_device.h (right):

https://codereview.chromium.org/2301073002/diff/1/ui/base/touch/touch_device....
ui/base/touch/touch_device.h:71: UI_BASE_EXPORT HoverType GetPrimaryHoverType();
Can you remove these old versions of the API?

[Tobias Sargeant, 2016-09-02 12:06:26]

The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 12:06:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tobias Sargeant, 2016-09-02 12:08:39]

tobiasjs@chromium.org changed reviewers:
+ miguelg@chromium.org

[Tobias Sargeant, 2016-09-02 12:08:39]

+miguelg for ui/android

[Tobias Sargeant, 2016-09-02 12:18:09]

https://codereview.chromium.org/2301073002/diff/1/ui/base/touch/touch_device.h
File ui/base/touch/touch_device.h (right):

https://codereview.chromium.org/2301073002/diff/1/ui/base/touch/touch_device....
ui/base/touch/touch_device.h:71: UI_BASE_EXPORT HoverType GetPrimaryHoverType();
On 2016/09/01 23:22:35, sadrul wrote:
> Can you remove these old versions of the API?

Done.

[sadrul, 2016-09-02 18:36:30]

Thanks! lgtm

https://codereview.chromium.org/2301073002/diff/40001/ui/base/touch/touch_dev...
File ui/base/touch/touch_device.cc (right):

https://codereview.chromium.org/2301073002/diff/40001/ui/base/touch/touch_dev...
ui/base/touch/touch_device.cc:51: }
I think you can remove the older versions from here too.

[Tobias Sargeant, 2016-09-05 15:32:33]

The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 15:32:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tobias Sargeant, 2016-09-05 15:42:24]

Description was changed from

==========
Optimization: avoid making 4 JNI calls to get touch device attributes.

Each call (Get{Available|Primary}{Pointer|Hover}Type) does a separate
iteration over the input device list, as well as incurring JNI call
overhead. By fetching the Pointer and Hover types in one call, and
then reusing the values, we can avoid unnecessary work on the WebView
startup path.

BUG=600060
==========

to

==========
Optimization: avoid making 4 JNI calls to get touch device attributes.

Each call (Get{Available|Primary}{Pointer|Hover}Type) does a separate
iteration over the input device list, as well as incurring JNI call
overhead. By fetching the Pointer and Hover types in one call, and
then reusing the values, we can avoid unnecessary work on the WebView
startup path.

BUG=600060
==========

[Tobias Sargeant, 2016-09-05 15:42:24]

tobiasjs@chromium.org changed reviewers:
+ twellington@chromium.org

[Tobias Sargeant, 2016-09-05 15:43:25]

Hi Theresa, if you have time, could you please take a look at ui/android?
Thanks.

[commit-bot: I haz the power, 2016-09-05 16:06:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 16:06:21]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Tobias Sargeant, 2016-09-06 13:47:55]

The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 13:48:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 15:34:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 15:34:06]

Dry run: This issue passed the CQ dry run.

[Theresa, 2016-09-06 16:35:23]

lgtm

[Tobias Sargeant, 2016-09-06 16:40:07]

The CQ bit was checked by tobiasjs@chromium.org

[Tobias Sargeant, 2016-09-06 16:40:07]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2301073002/#ps80001
(title: "Fix windows compile issues")

[commit-bot: I haz the power, 2016-09-06 16:40:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 16:44:49]

Description was changed from

==========
Optimization: avoid making 4 JNI calls to get touch device attributes.

Each call (Get{Available|Primary}{Pointer|Hover}Type) does a separate
iteration over the input device list, as well as incurring JNI call
overhead. By fetching the Pointer and Hover types in one call, and
then reusing the values, we can avoid unnecessary work on the WebView
startup path.

BUG=600060
==========

to

==========
Optimization: avoid making 4 JNI calls to get touch device attributes.

Each call (Get{Available|Primary}{Pointer|Hover}Type) does a separate
iteration over the input device list, as well as incurring JNI call
overhead. By fetching the Pointer and Hover types in one call, and
then reusing the values, we can avoid unnecessary work on the WebView
startup path.

BUG=600060
==========

[commit-bot: I haz the power, 2016-09-06 16:44:50]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-06 16:48:23]

Description was changed from

==========
Optimization: avoid making 4 JNI calls to get touch device attributes.

Each call (Get{Available|Primary}{Pointer|Hover}Type) does a separate
iteration over the input device list, as well as incurring JNI call
overhead. By fetching the Pointer and Hover types in one call, and
then reusing the values, we can avoid unnecessary work on the WebView
startup path.

BUG=600060
==========

to

==========
Optimization: avoid making 4 JNI calls to get touch device attributes.

Each call (Get{Available|Primary}{Pointer|Hover}Type) does a separate
iteration over the input device list, as well as incurring JNI call
overhead. By fetching the Pointer and Hover types in one call, and
then reusing the values, we can avoid unnecessary work on the WebView
startup path.

BUG=600060

Committed: https://crrev.com/4cef7d0449592119bc8bdee2b5a98c89543f4c03
Cr-Commit-Position: refs/heads/master@{#416644}
==========

[commit-bot: I haz the power, 2016-09-06 16:48:23]

Patchset 5 (id:??) landed as
https://crrev.com/4cef7d0449592119bc8bdee2b5a98c89543f4c03
Cr-Commit-Position: refs/heads/master@{#416644}