Image Capture: adding fillLightMode getting/setting

Image Capture: adding fillLightMode getting/setting

This CL wires getting/setting |fillLightMode| parameter
in idl/mojom/jni files, updating LayoutTests.

Factored out photo-related settings configuration
in VCCamera2.java in configureCommonCaptureSettings(),
that is also a bit polished for better understanding
of how 3A configurations work together.

Also renamed MeteringMode's "unavailable" with "none"
following the Spec. ("none" is more descriptive since
it's used for getting and setting state).

BUG=518807
Committed: https://crrev.com/abcfdd784d989a8f671d414b7505ddafbb9b7cad
Cr-Commit-Position: refs/heads/master@{#416437}

[mcasas, 2016-09-02 02:16:49]

Description was changed from

==========
Image Capture: adding fillLightMode getting/setting

BUG=518807
==========

to

==========
Image Capture: adding fillLightMode getting/setting

This CL wires getting/setting |fillLightMode| parameter
in idl/mojom/jni files, updating LayoutTests.

Factored out photo-related settings configuration 
in VCCamera2.java in configureCommonCaptureSettings(),
that is also a bit polished for better understanding
of how 3A configurations work together.

Also renamed MeteringMode's "unavailable" with "none"
following the Spec. ("none" is more descriptive since
it's used for getting and setting state).

BUG=518807
==========

[mcasas, 2016-09-02 02:17:06]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-09-02 14:42:22]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-09-02 16:51:27]

mcasas@chromium.org changed reviewers:
+ scheib@chromium.org, tsepez@chromium.org

[mcasas, 2016-09-02 16:51:28]

tsepez@ mojom Owners RS plz

scheib@ PTAL

[Tom Sepez, 2016-09-02 17:48:32]

mojom lgtm

[scheib, 2016-09-03 00:21:58]

LGTM -ish ... lots of additional enums and logic in android doesn't have test
coverage.

Also nit-suggestions:

https://codereview.chromium.org/2301053004/diff/40001/media/capture/video/and...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
(right):

https://codereview.chromium.org/2301053004/diff/40001/media/capture/video/and...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:526:
default:
In C++ we have the compiler warning configured as error if the switch doesn't
contain all enum values. By omitting the default parameter you can make the code
less brittle, because a change in the enum options will be a compile error if
not also reflected here.

https://codereview.chromium.org/2301053004/diff/40001/media/capture/video/and...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
(right):

https://codereview.chromium.org/2301053004/diff/40001/media/capture/video/and...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:390:
// TODO(mcasas): support different luminant color temperatures, e.g. DAYLIGHT,
SHADE.
I've jumped to the 'always TODO(issue#)' style based on the chromium-dev
discussion that happened several months ago. TODOs based on issue capture not
only WHO knows the information, but ensure there IS an issue so that the work is
tracked and can sit in a known backlog and be harder to forget. It also helps
when an issue ends up creating a few TODOs in code over time.

[mcasas, 2016-09-03 01:21:07]

https://codereview.chromium.org/2301053004/diff/40001/media/capture/video/and...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
(right):

https://codereview.chromium.org/2301053004/diff/40001/media/capture/video/and...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:526:
default:
On 2016/09/03 00:21:57, scheib wrote:
> In C++ we have the compiler warning configured as error if the switch doesn't
> contain all enum values. By omitting the default parameter you can make the
code
> less brittle, because a change in the enum options will be a compile error if
> not also reflected here.

I understand and I did it in the first pass, but
there is an analyze step in some android bot
that runs a tool (I think it's findbugs.py?) and
that complained exactly because there was no
default: case.

https://codereview.chromium.org/2301053004/diff/40001/media/capture/video/and...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
(right):

https://codereview.chromium.org/2301053004/diff/40001/media/capture/video/and...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:390:
// TODO(mcasas): support different luminant color temperatures, e.g. DAYLIGHT,
SHADE.
On 2016/09/03 00:21:57, scheib wrote:
> I've jumped to the 'always TODO(issue#)' style based on the chromium-dev
> discussion that happened several months ago. TODOs based on issue capture not
> only WHO knows the information, but ensure there IS an issue so that the work
is
> tracked and can sit in a known backlog and be harder to forget. It also helps
> when an issue ends up creating a few TODOs in code over time.

I know, this was just me being lazy since
I'm working on this imminently, but indeed
I should practice what I preach :)

Also, the github PR is already merged in, so 
the more the reason to remove l.391

[mcasas, 2016-09-03 01:21:15]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-09-03 01:21:15]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2301053004/#ps60001
(title: "scheib@s comments, added #crbug")

[commit-bot: I haz the power, 2016-09-03 01:21:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 03:26:49]

Description was changed from

==========
Image Capture: adding fillLightMode getting/setting

This CL wires getting/setting |fillLightMode| parameter
in idl/mojom/jni files, updating LayoutTests.

Factored out photo-related settings configuration 
in VCCamera2.java in configureCommonCaptureSettings(),
that is also a bit polished for better understanding
of how 3A configurations work together.

Also renamed MeteringMode's "unavailable" with "none"
following the Spec. ("none" is more descriptive since
it's used for getting and setting state).

BUG=518807
==========

to

==========
Image Capture: adding fillLightMode getting/setting

This CL wires getting/setting |fillLightMode| parameter
in idl/mojom/jni files, updating LayoutTests.

Factored out photo-related settings configuration 
in VCCamera2.java in configureCommonCaptureSettings(),
that is also a bit polished for better understanding
of how 3A configurations work together.

Also renamed MeteringMode's "unavailable" with "none"
following the Spec. ("none" is more descriptive since
it's used for getting and setting state).

BUG=518807
==========

[commit-bot: I haz the power, 2016-09-03 03:26:51]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-09-03 03:28:52]

Description was changed from

==========
Image Capture: adding fillLightMode getting/setting

This CL wires getting/setting |fillLightMode| parameter
in idl/mojom/jni files, updating LayoutTests.

Factored out photo-related settings configuration 
in VCCamera2.java in configureCommonCaptureSettings(),
that is also a bit polished for better understanding
of how 3A configurations work together.

Also renamed MeteringMode's "unavailable" with "none"
following the Spec. ("none" is more descriptive since
it's used for getting and setting state).

BUG=518807
==========

to

==========
Image Capture: adding fillLightMode getting/setting

This CL wires getting/setting |fillLightMode| parameter
in idl/mojom/jni files, updating LayoutTests.

Factored out photo-related settings configuration
in VCCamera2.java in configureCommonCaptureSettings(),
that is also a bit polished for better understanding
of how 3A configurations work together.

Also renamed MeteringMode's "unavailable" with "none"
following the Spec. ("none" is more descriptive since
it's used for getting and setting state).

BUG=518807

Committed: https://crrev.com/abcfdd784d989a8f671d414b7505ddafbb9b7cad
Cr-Commit-Position: refs/heads/master@{#416437}
==========

[commit-bot: I haz the power, 2016-09-03 03:28:53]

Patchset 2 (id:??) landed as
https://crrev.com/abcfdd784d989a8f671d414b7505ddafbb9b7cad
Cr-Commit-Position: refs/heads/master@{#416437}