[Downloads] Ask DownloadHistory if a download was from history.

chrome/browser/download/download_ui_controller_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "chrome/browser/download/download_ui_controller.h"
 #include "content/public/test/mock_download_item.h"
 #include "content/public/test/mock_download_manager.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 39 matching lines @@
   virtual void SetUp() OVERRIDE;
 
   // Returns a MockDownloadItem that has AddObserver and RemoveObserver
   // expectations set up to store the observer in |item_observer_|.
   scoped_ptr<MockDownloadItem> GetMockDownload();
 
   // Returns a TestDelegate. Invoking NotifyDownloadStarting on the returned
   // delegate results in the DownloadItem* being stored in |received_item_|.
   scoped_ptr<DownloadUIController::Delegate> GetTestDelegate();
 
+  DownloadUIController::DownloadFilter NewDownloadPredicate(bool value);
+
   MockDownloadManager* manager() { return manager_.get(); }
   content::DownloadManager::Observer* manager_observer() {
     return manager_observer_;
   }
   content::DownloadItem::Observer* item_observer() { return item_observer_; }
   content::DownloadItem* received_item() { return received_item_; }
 
  private:
   scoped_ptr<MockDownloadManager> manager_;
   content::DownloadManager::Observer* manager_observer_;
@@ skipping 31 matching lines @@
   return item.Pass();
 }
 
 scoped_ptr<DownloadUIController::Delegate>
 DownloadUIControllerTest::GetTestDelegate() {
   scoped_ptr<DownloadUIController::Delegate> delegate(
       new TestDelegate(receiver_factory_.GetWeakPtr()));
   return delegate.Pass();
 }
 
-// Normal downloads that are constructed in the IN_PROGRESS state should be
-// presented to the UI when GetTargetFilePath() returns a non-empty path.
-// I.e. once the download target has been determined.
+bool StaticDownloadItemPredicate(bool value, const content::DownloadItem*) {
+  return value;
+}
+
+DownloadUIController::DownloadFilter
+DownloadUIControllerTest::NewDownloadPredicate(bool value) {
+  return base::Bind(&StaticDownloadItemPredicate, value);
+}
+
+// New downloads should be presented to the UI when GetTargetFilePath() returns
+// a non-empty path.  I.e. once the download target has been determined.
 TEST_F(DownloadUIControllerTest, DownloadUIController_NotifyBasic) {
   scoped_ptr<MockDownloadItem> item = GetMockDownload();
-  DownloadUIController controller(manager(), GetTestDelegate());
+  DownloadUIController controller(
+      manager(), NewDownloadPredicate(true), GetTestDelegate());
   EXPECT_CALL(*item, GetTargetFilePath())
       .WillOnce(ReturnRefOfCopy(base::FilePath()));
   EXPECT_CALL(*item, GetState())
       .WillRepeatedly(Return(content::DownloadItem::IN_PROGRESS));
 
   ASSERT_TRUE(manager_observer());
   manager_observer()->OnDownloadCreated(manager(), item.get());
 
   // The destination for the download hasn't been determined yet. It should not
   // be displayed.
   EXPECT_FALSE(received_item());
   ASSERT_TRUE(item_observer());
 
   // Once the destination has been determined, then it should be displayed.
   EXPECT_CALL(*item, GetTargetFilePath())
       .WillOnce(ReturnRefOfCopy(base::FilePath(FILE_PATH_LITERAL("foo"))));
   item_observer()->OnDownloadUpdated(item.get());
 
   EXPECT_EQ(static_cast<content::DownloadItem*>(item.get()), received_item());
 }
 
+// A download that's created in an interrupted state should also be displayed if
+// the new download filter flags it as a new download.
+TEST_F(DownloadUIControllerTest, DownloadUIController_NotifyBasic_Interrupted) {
+  scoped_ptr<MockDownloadItem> item = GetMockDownload();
+  DownloadUIController controller(
+      manager(), NewDownloadPredicate(true), GetTestDelegate());
+  EXPECT_CALL(*item, GetTargetFilePath())
+      .WillOnce(ReturnRefOfCopy(base::FilePath(FILE_PATH_LITERAL("foo"))));
+  EXPECT_CALL(*item, GetState())
+      .WillRepeatedly(Return(content::DownloadItem::INTERRUPTED));
+
+  ASSERT_TRUE(manager_observer());
+  manager_observer()->OnDownloadCreated(manager(), item.get());
+  EXPECT_EQ(static_cast<content::DownloadItem*>(item.get()), received_item());
+}
+
 // Downloads that have a target path on creation and are in the IN_PROGRESS
 // state should be displayed in the UI immediately without requiring an
 // additional OnDownloadUpdated() notification.
 TEST_F(DownloadUIControllerTest, DownloadUIController_NotifyReadyOnCreate) {
   scoped_ptr<MockDownloadItem> item = GetMockDownload();
-  DownloadUIController controller(manager(), GetTestDelegate());
+  DownloadUIController controller(
+      manager(), NewDownloadPredicate(true), GetTestDelegate());
   EXPECT_CALL(*item, GetTargetFilePath())
       .WillOnce(ReturnRefOfCopy(base::FilePath(FILE_PATH_LITERAL("foo"))));
   EXPECT_CALL(*item, GetState())
       .WillRepeatedly(Return(content::DownloadItem::IN_PROGRESS));
 
   ASSERT_TRUE(manager_observer());
   manager_observer()->OnDownloadCreated(manager(), item.get());
   EXPECT_EQ(static_cast<content::DownloadItem*>(item.get()), received_item());
 }
 
-// History downloads (downloads that are not in IN_PROGRESS on create) should
-// not be displayed on the shelf.
+// Downloads that are flagged by the new download filter as not being a new
+// download at the time OnDownloadCreated is called should not be displayed in
+// the UI.
 TEST_F(DownloadUIControllerTest, DownloadUIController_NoNotifyHistory) {
   scoped_ptr<MockDownloadItem> item = GetMockDownload();
-  DownloadUIController controller(manager(), GetTestDelegate());
+  DownloadUIController controller(
+      manager(), NewDownloadPredicate(false), GetTestDelegate());
   EXPECT_CALL(*item, GetState())
       .WillRepeatedly(Return(content::DownloadItem::COMPLETE));
 
   ASSERT_TRUE(manager_observer());
   manager_observer()->OnDownloadCreated(manager(), item.get());
   EXPECT_FALSE(received_item());
 
   item_observer()->OnDownloadUpdated(item.get());
   EXPECT_FALSE(received_item());
 }
 
 } // namespace