Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js

Issue 2301023003: DevTools: fix disposing of main debugger script mappings (Closed)
Patch Set: main debugger mappings do not leak memory Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @implements {WebInspector.DebuggerSourceMapping} 7 * @implements {WebInspector.DebuggerSourceMapping}
8 * @param {!WebInspector.DebuggerModel} debuggerModel 8 * @param {!WebInspector.DebuggerModel} debuggerModel
9 * @param {!WebInspector.ScriptFormatterEditorAction} editorAction 9 * @param {!WebInspector.ScriptFormatterEditorAction} editorAction
10 */ 10 */
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 /** 72 /**
73 * @override 73 * @override
74 * @param {!WebInspector.UISourceCode} uiSourceCode 74 * @param {!WebInspector.UISourceCode} uiSourceCode
75 * @param {number} lineNumber 75 * @param {number} lineNumber
76 * @return {boolean} 76 * @return {boolean}
77 */ 77 */
78 uiLineHasMapping: function(uiSourceCode, lineNumber) 78 uiLineHasMapping: function(uiSourceCode, lineNumber)
79 { 79 {
80 return true; 80 return true;
81 } 81 }
82
83 } 82 }
84 83
85 /** 84 /**
86 * @constructor 85 * @constructor
87 * @param {string} projectId 86 * @param {string} projectId
88 * @param {string} path 87 * @param {string} path
89 * @param {!WebInspector.FormatterSourceMapping} mapping 88 * @param {!WebInspector.FormatterSourceMapping} mapping
90 * @param {!Array.<!WebInspector.Script>} scripts 89 * @param {!Array.<!WebInspector.Script>} scripts
91 */ 90 */
92 WebInspector.FormatterScriptMapping.FormatData = function(projectId, path, mappi ng, scripts) 91 WebInspector.FormatterScriptMapping.FormatData = function(projectId, path, mappi ng, scripts)
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 386
388 var targets = WebInspector.targetManager.targets(); 387 var targets = WebInspector.targetManager.targets();
389 for (var i = 0; i < targets.length; ++i) { 388 for (var i = 0; i < targets.length; ++i) {
390 var scriptMapping = /** @type {!WebInspector.FormatterScriptMapp ing} */(this._scriptMappingByTarget.get(targets[i])); 389 var scriptMapping = /** @type {!WebInspector.FormatterScriptMapp ing} */(this._scriptMappingByTarget.get(targets[i]));
391 WebInspector.debuggerWorkspaceBinding.setSourceMapping(targets[i ], formattedUISourceCode, scriptMapping); 390 WebInspector.debuggerWorkspaceBinding.setSourceMapping(targets[i ], formattedUISourceCode, scriptMapping);
392 } 391 }
393 this._showIfNeeded(uiSourceCode, formattedUISourceCode, formatterMap ping); 392 this._showIfNeeded(uiSourceCode, formattedUISourceCode, formatterMap ping);
394 } 393 }
395 } 394 }
396 } 395 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698