DevTools: fix disposing of main debugger script mappings

DevTools: fix disposing of main debugger script mappings

This patch fixes disposing of:
- DefaultScriptmapping
- ResourceScriptMapping
- CompilerScriptMapping

BUG=none
R=dgozman

Committed: https://crrev.com/8ecbbdd50c56c6f62d7e78294dddca6b364b35fb
Cr-Commit-Position: refs/heads/master@{#417199}

[lushnikov, 2016-09-01 19:19:08]

please, take a look

[lushnikov, 2016-09-01 19:19:57]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 19:20:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 20:38:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 20:38:01]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-09-02 21:05:10]

lgtm

https://codereview.chromium.org/2301023003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
(right):

https://codereview.chromium.org/2301023003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js:59:
var projectId =
WebInspector.CompilerScriptMapping.projectIdForTarget(this._target);
Let's have a test for sourcemaps in multiple targets at the same time.

[lushnikov, 2016-09-08 01:32:04]

https://codereview.chromium.org/2301023003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
(right):

https://codereview.chromium.org/2301023003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js:59:
var projectId =
WebInspector.CompilerScriptMapping.projectIdForTarget(this._target);
On 2016/09/02 21:05:10, dgozman wrote:
> Let's have a test for sourcemaps in multiple targets at the same time.

Sourcemaps actually work; the stubproject works too.

The problem is that the workspace should not allow adding projects with the same
ID.

I'll put an assert in a follow-up in the workspace.addProject to verify we do
not override
projects. Unfortunately, we do override projects a lot, so some code changes
need to be done.

[lushnikov, 2016-09-08 01:32:33]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-09-08 01:32:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 05:48:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 05:51:20]

Description was changed from

==========
DevTools: fix disposing of main debugger script mappings

This patch fixes disposing of:
- DefaultScriptmapping
- ResourceScriptMapping
- CompilerScriptMapping

BUG=none
R=dgozman
==========

to

==========
DevTools: fix disposing of main debugger script mappings

This patch fixes disposing of:
- DefaultScriptmapping
- ResourceScriptMapping
- CompilerScriptMapping

BUG=none
R=dgozman

Committed: https://crrev.com/8ecbbdd50c56c6f62d7e78294dddca6b364b35fb
Cr-Commit-Position: refs/heads/master@{#417199}
==========

[commit-bot: I haz the power, 2016-09-08 05:51:21]

Patchset 2 (id:??) landed as
https://crrev.com/8ecbbdd50c56c6f62d7e78294dddca6b364b35fb
Cr-Commit-Position: refs/heads/master@{#417199}