Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2301023002: Ntp: adjust footer spacing. (Closed)

Created:
4 years, 3 months ago by Michael van Ouwerkerk
Modified:
4 years, 3 months ago
Reviewers:
PEConn, gone
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ntp: adjust footer spacing. BUG=643104 Committed: https://crrev.com/480feb5b4f17cca6a327cf1640ca318b64a92216 Cr-Commit-Position: refs/heads/master@{#416225}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove minimum bottom spacing. It's just 0. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/android/java/res/layout/new_tab_page_footer.xml View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java View 1 4 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
4 years, 3 months ago (2016-09-01 13:39:45 UTC) #4
PEConn
https://codereview.chromium.org/2301023002/diff/1/chrome/android/java/res/values/dimens.xml File chrome/android/java/res/values/dimens.xml (right): https://codereview.chromium.org/2301023002/diff/1/chrome/android/java/res/values/dimens.xml#newcode280 chrome/android/java/res/values/dimens.xml:280: <dimen name="ntp_min_bottom_spacing_recycler_view">0dp</dimen> Do we need this anymore?
4 years, 3 months ago (2016-09-01 15:38:11 UTC) #7
Michael van Ouwerkerk
Thanks Peter. Please take another look. https://codereview.chromium.org/2301023002/diff/1/chrome/android/java/res/values/dimens.xml File chrome/android/java/res/values/dimens.xml (right): https://codereview.chromium.org/2301023002/diff/1/chrome/android/java/res/values/dimens.xml#newcode280 chrome/android/java/res/values/dimens.xml:280: <dimen name="ntp_min_bottom_spacing_recycler_view">0dp</dimen> On ...
4 years, 3 months ago (2016-09-01 15:54:33 UTC) #10
PEConn
LGTM
4 years, 3 months ago (2016-09-01 15:56:03 UTC) #11
Michael van Ouwerkerk
Dan: please review as OWNER for files in chrome/android/java/res/
4 years, 3 months ago (2016-09-01 16:07:24 UTC) #13
gone
OWNERS lgtm
4 years, 3 months ago (2016-09-01 17:33:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301023002/20001
4 years, 3 months ago (2016-09-02 09:38:46 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 09:42:25 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 09:44:48 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/480feb5b4f17cca6a327cf1640ca318b64a92216
Cr-Commit-Position: refs/heads/master@{#416225}

Powered by Google App Engine
This is Rietveld 408576698