Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2300993003: CmaRenderer is dead. Long live MojoRenderer. (Closed)

Created:
4 years, 3 months ago by alokp
Modified:
4 years, 3 months ago
CC:
DaleCurtis, alokp+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, lcwu+watch_chromium.org, lcwu1, posciak+watch_chromium.org, sandersd (OOO until July 31), xhwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CmaRenderer is dead. Long live MojoRenderer. BUG=571155 Committed: https://crrev.com/60fb6b0f601074d94dc03bbea9f1351f678f18fa Cr-Commit-Position: refs/heads/master@{#416361}

Patch Set 1 #

Total comments: 2

Patch Set 2 : update cmdline for cast-linux bot #

Patch Set 3 : rebase #

Patch Set 4 : update OWNERS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7081 lines) Patch
M chromecast/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/base/chromecast_switches.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chromecast/base/chromecast_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D chromecast/base/chromecast_switches_unittest.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 1 2 4 chunks +3 lines, -25 lines 0 comments Download
M chromecast/browser/media/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
D chromecast/browser/media/cma_message_filter_host.h View 1 chunk +0 lines, -133 lines 0 comments Download
D chromecast/browser/media/cma_message_filter_host.cc View 1 chunk +0 lines, -543 lines 0 comments Download
D chromecast/browser/media/media_pipeline_host.h View 1 chunk +0 lines, -94 lines 0 comments Download
D chromecast/browser/media/media_pipeline_host.cc View 1 chunk +0 lines, -183 lines 0 comments Download
M chromecast/common/media/BUILD.gn View 2 chunks +0 lines, -37 lines 0 comments Download
M chromecast/common/media/OWNERS View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
D chromecast/common/media/cma_ipc_common.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chromecast/common/media/cma_message_generator.h View 1 chunk +0 lines, -8 lines 0 comments Download
D chromecast/common/media/cma_message_generator.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D chromecast/common/media/cma_messages.h View 1 chunk +0 lines, -113 lines 0 comments Download
D chromecast/common/media/cma_param_traits.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chromecast/common/media/cma_param_traits.cc View 1 chunk +0 lines, -170 lines 0 comments Download
D chromecast/common/media/cma_param_traits_macros.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chromecast/common/media/shared_memory_chunk.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chromecast/common/media/shared_memory_chunk.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M chromecast/media/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M chromecast/media/cma/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chromecast/media/cma/ipc/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D chromecast/media/cma/ipc/media_memory_chunk.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chromecast/media/cma/ipc/media_memory_chunk.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D chromecast/media/cma/ipc/media_message.h View 1 chunk +0 lines, -166 lines 0 comments Download
D chromecast/media/cma/ipc/media_message.cc View 1 chunk +0 lines, -200 lines 0 comments Download
D chromecast/media/cma/ipc/media_message_fifo.h View 1 chunk +0 lines, -213 lines 0 comments Download
D chromecast/media/cma/ipc/media_message_fifo.cc View 1 chunk +0 lines, -405 lines 0 comments Download
D chromecast/media/cma/ipc/media_message_fifo_unittest.cc View 1 chunk +0 lines, -191 lines 0 comments Download
D chromecast/media/cma/ipc/media_message_type.h View 1 chunk +0 lines, -15 lines 0 comments Download
D chromecast/media/cma/ipc/media_message_unittest.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/BUILD.gn View 1 chunk +0 lines, -34 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/audio_decoder_config_marshaller.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/audio_decoder_config_marshaller.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/av_streamer_proxy.h View 1 chunk +0 lines, -96 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/av_streamer_proxy.cc View 1 chunk +0 lines, -216 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/av_streamer_unittest.cc View 1 chunk +0 lines, -322 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/coded_frame_provider_host.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/coded_frame_provider_host.cc View 1 chunk +0 lines, -96 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/decoder_buffer_base_marshaller.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/decoder_buffer_base_marshaller.cc View 1 chunk +0 lines, -193 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/decrypt_config_marshaller.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/decrypt_config_marshaller.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/encryption_scheme_marshaller.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/encryption_scheme_marshaller.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/video_decoder_config_marshaller.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chromecast/media/cma/ipc_streamer/video_decoder_config_marshaller.cc View 1 chunk +0 lines, -123 lines 0 comments Download
M chromecast/renderer/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chromecast/renderer/cast_content_renderer_client.h View 3 chunks +0 lines, -8 lines 0 comments Download
M chromecast/renderer/cast_content_renderer_client.cc View 3 chunks +0 lines, -20 lines 0 comments Download
D chromecast/renderer/cast_render_thread_observer.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chromecast/renderer/cast_render_thread_observer.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M chromecast/renderer/media/BUILD.gn View 2 chunks +0 lines, -34 lines 0 comments Download
D chromecast/renderer/media/audio_pipeline_proxy.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chromecast/renderer/media/audio_pipeline_proxy.cc View 1 chunk +0 lines, -310 lines 0 comments Download
D chromecast/renderer/media/chromecast_media_renderer_factory.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chromecast/renderer/media/chromecast_media_renderer_factory.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D chromecast/renderer/media/cma_message_filter_proxy.h View 1 chunk +0 lines, -137 lines 0 comments Download
D chromecast/renderer/media/cma_message_filter_proxy.cc View 1 chunk +0 lines, -281 lines 0 comments Download
D chromecast/renderer/media/cma_renderer.h View 1 chunk +0 lines, -149 lines 0 comments Download
D chromecast/renderer/media/cma_renderer.cc View 1 chunk +0 lines, -459 lines 0 comments Download
D chromecast/renderer/media/media_channel_proxy.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chromecast/renderer/media/media_channel_proxy.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D chromecast/renderer/media/media_pipeline_proxy.h View 1 chunk +0 lines, -84 lines 0 comments Download
D chromecast/renderer/media/media_pipeline_proxy.cc View 1 chunk +0 lines, -279 lines 0 comments Download
D chromecast/renderer/media/video_pipeline_proxy.h View 1 chunk +0 lines, -74 lines 0 comments Download
D chromecast/renderer/media/video_pipeline_proxy.cc View 1 chunk +0 lines, -300 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 28 (11 generated)
alokp
This will land after: https://codereview.chromium.org/2279863003/
4 years, 3 months ago (2016-09-01 21:06:16 UTC) #2
DaleCurtis
\o/
4 years, 3 months ago (2016-09-01 21:08:32 UTC) #3
servolk
On 2016/09/01 21:06:16, alokp wrote: > This will land after: > https://codereview.chromium.org/2279863003/ lgtm, thanks!
4 years, 3 months ago (2016-09-01 22:13:25 UTC) #4
halliwell
On 2016/09/01 22:13:25, servolk wrote: > On 2016/09/01 21:06:16, alokp wrote: > > This will ...
4 years, 3 months ago (2016-09-01 22:38:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300993003/20001
4 years, 3 months ago (2016-09-02 02:25:13 UTC) #7
alokp
dpranke@: testing/buildbot/
4 years, 3 months ago (2016-09-02 02:27:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/251802)
4 years, 3 months ago (2016-09-02 02:32:17 UTC) #11
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-02 16:55:40 UTC) #12
slan
lgtm - woohoo! https://codereview.chromium.org/2300993003/diff/1/chromecast/browser/cast_browser_main_parts.cc File chromecast/browser/cast_browser_main_parts.cc (right): https://codereview.chromium.org/2300993003/diff/1/chromecast/browser/cast_browser_main_parts.cc#newcode234 chromecast/browser/cast_browser_main_parts.cc:234: #elif defined(ARCH_CPU_ARM_FAMILY) Unrelated, but how does ...
4 years, 3 months ago (2016-09-02 16:57:13 UTC) #13
alokp
https://codereview.chromium.org/2300993003/diff/1/chromecast/browser/cast_browser_main_parts.cc File chromecast/browser/cast_browser_main_parts.cc (right): https://codereview.chromium.org/2300993003/diff/1/chromecast/browser/cast_browser_main_parts.cc#newcode234 chromecast/browser/cast_browser_main_parts.cc:234: #elif defined(ARCH_CPU_ARM_FAMILY) On 2016/09/02 16:57:13, slan wrote: > Unrelated, ...
4 years, 3 months ago (2016-09-02 17:04:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300993003/20001
4 years, 3 months ago (2016-09-02 17:04:44 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/252219)
4 years, 3 months ago (2016-09-02 17:11:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300993003/60001
4 years, 3 months ago (2016-09-02 17:21:54 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/286702)
4 years, 3 months ago (2016-09-02 19:38:05 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300993003/60001
4 years, 3 months ago (2016-09-02 20:47:04 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-02 22:08:33 UTC) #26
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 22:11:57 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/60fb6b0f601074d94dc03bbea9f1351f678f18fa
Cr-Commit-Position: refs/heads/master@{#416361}

Powered by Google App Engine
This is Rietveld 408576698