Issue 2300993002: Don't make main async in the asyncstar_main_test file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2300993002: Don't make main async in the asyncstar_main_test file. (Closed)

Created:
4 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
4 years, 3 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Don't make main async in the asyncstar_main_test file. The framework thinks the test is done before it gets started. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/3c798ed008e15719dbbc235afa87d09acb666bc4

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	tests/language/yieldstar_pause_test.dart	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 6 (2 generated)

Lasse Reichstein Nielsen

4 years, 3 months ago (2016-09-01 12:29:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3c798ed008e15719dbbc235afa87d09acb666bc4 (presubmit successful).